-
Notifications
You must be signed in to change notification settings - Fork 733
chore: drop Aspire.Cli.Tests unwanted dependencies #10422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures and cleans up the end-to-end tests for the aspire exec feature by moving them into the Aspire.Hosting.Tests project and removing the old Aspire.Cli.Tests suite along with unwanted project dependencies.
- Introduces a new
ProjectResourceExecTestsclass andExecTestsBasehelper inAspire.Hosting.Testsfor backchannel-based exec testing. - Deletes the legacy E2E exec tests in
tests/Aspire.Cli.Tests/E2E/ExecTests.cs. - Cleans up
Aspire.Cli.Tests.csprojby removing references toAspire.TestUtilitiesand playground apps.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/Backchannel/Exec/ProjectResourceExecTests.cs | Adds new backchannel-based exec tests for project resources |
| tests/Aspire.Hosting.Tests/Backchannel/Exec/ExecTestsBase.cs | Adds base class for shared exec test logic |
| tests/Aspire.Cli.Tests/E2E/ExecTests.cs | Removes old E2E exec tests and their dependencies |
| tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj | Drops unwanted project references (TestUtilities and playground apps) |
|
I think we might need a bit more test coverage on the CLI side which simulates various error conditions coming back across a fake backchannel. If you look at These new tests without the external project dependency look OK though so I'll approve this PR. |
i will do in a follow-up pr, merging this to unblock other activities; thanks Mitch! |
|
/backport to release/9.4 |
|
Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16386346021 |
|
@DeagleGross need to remember to backport these PRs :) |
|
@mitchdenny backporting to "release/9.4" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: drop dependencies
Using index info to reconstruct a base tree...
M tests/Aspire.Cli.Tests/E2E/ExecTests.cs
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): tests/Aspire.Cli.Tests/E2E/ExecTests.cs deleted in drop dependencies and modified in HEAD. Version HEAD of tests/Aspire.Cli.Tests/E2E/ExecTests.cs left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 drop dependencies
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
* drop dependencies (#10422) * Add missing using. * Add missing usings. --------- Co-authored-by: Korolev Dmitry <[email protected]>
This PR moves the existing "e2e" tests validating
aspire execscenario, and drops the unwanted dependencies such as playground apps of theAspire.Cli.Testsproject.Fixes #10421