Skip to content

Update hosted VS 2017 usage to 2019, including private pool provider builds (release 5.0) #8123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MattGal merged 1 commit into from
Nov 2, 2021
Merged

Update hosted VS 2017 usage to 2019, including private pool provider builds (release 5.0) #8123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure-pipelines-code-mirror.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
jobs:
- job: Merge_GitHub_to_Azure_DevOps
pool:
name: Hosted VS2017
vmImage: windows-2019
variables:
- name: WorkingDirectoryName
value: repo-dir
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines-merge-mirror.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
jobs:
- job: Merge_GitHub_to_Azure_DevOps
pool:
name: Hosted VS2017
vmImage: windows-2019
variables:
- name: WorkingDirectoryName
value: repo-dir
Expand Down
4 changes: 2 additions & 2 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ stages:
pool:
${{ if eq(variables._RunAsPublic, True) }}:
name: NetCore1ESPool-Svc-Public
demands: ImageOverride -equals Build.Server.Amd64.VS2017.Open
demands: ImageOverride -equals Build.Server.Amd64.VS2019.Open
${{ if eq(variables._RunAsInternal, True) }}:
name: NetCore1ESPool-Svc-Internal
demands: ImageOverride -equals Build.Server.Amd64.VS2017
demands: ImageOverride -equals Build.Server.Amd64.VS2019
strategy:
matrix:
Build_Release:
Expand Down
2 changes: 1 addition & 1 deletion eng/common/templates/job/execute-sdl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: AzDOBuildId
value: $[ dependencies.setupMaestroVars.outputs['setReleaseVars.AzDOBuildId'] ]
pool:
name: Hosted VS2017
vmImage: windows-2019
steps:
- checkout: self
clean: true
Expand Down
2 changes: 1 addition & 1 deletion eng/common/templates/job/onelocbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ parameters:

# Optional: A defined YAML pool - https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=vsts&tabs=schema#pool
pool:
vmImage: vs2017-win2016
vmImage: windows-2019

CeapexPat: $(dn-bot-ceapex-package-r) # PAT for the loc AzDO instance https://dev.azure.com/ceapex
GithubPat: $(BotAccount-dotnet-bot-repo-PAT)
Expand Down
4 changes: 2 additions & 2 deletions eng/common/templates/jobs/jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
- ${{ if eq(parameters.runSourceBuild, true) }}:
- Source_Build_Complete
pool:
vmImage: vs2017-win2016
vmImage: windows-2019
runAsPublic: ${{ parameters.runAsPublic }}
publishUsingPipelines: ${{ parameters.enablePublishUsingPipelines }}
enablePublishBuildArtifacts: ${{ parameters.enablePublishBuildArtifacts }}
Expand All @@ -85,4 +85,4 @@ jobs:
dependsOn:
- Asset_Registry_Publish
pool:
vmImage: vs2017-win2016
vmImage: windows-2019
2 changes: 1 addition & 1 deletion eng/validate-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
timeoutInMinutes: 90
pool:
name: NetCore1ESPool-Svc-Internal
demands: ImageOverride -equals Build.Server.Amd64.VS2017
demands: ImageOverride -equals Build.Server.Amd64.VS2019
variables:
- group: DotNet-Blob-Feed
- group: Publish-Build-Assets
Expand Down