Update hosted VS 2017 usage to 2019, including private pool provider builds (release 5.0) #8123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in anticipation of the win2016-vs2017 image's deprecation this month, tracking issue https://github.com/dotnet/core-eng/issues/14783
To double check:
ASK Mode template information:
Description
Hosted windows images based off Server 2016 / VS 2017 are being deprecated starting this month, and fully removed (will cause build failure) in March 2022. The oldest VS available after this time will be VS 2019. This change updates to an image that will last through at least 2023, and makes the parallel change in the 1ES pool provider images used.
Customer Impact
If not addressed, all builds using hosted images in Arcade and repositories dependent on this branch of Arcade will break, making updating or using common yaml template functionality broken.
Regression
No
Risk
Low-to-medium; Most Arcade builds don't depend on the installed copy of VS of the machine, but since the eng/common folders are changed as well, teams building VS-sensitive components in other repos may have to fix up their build to succeed on VS > 2017.
Workarounds
No workaround without changing source can solve this problem as the deprecated image name / vmImage tag is in the source.