-
Notifications
You must be signed in to change notification settings - Fork 376
Run test PublishToSymbolServers to validate sdk-tesk.ps1 script #7708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run test PublishToSymbolServers to validate sdk-tesk.ps1 script #7708
Conversation
|
Do you have a test build with this validation running? Would it be possible to add this to the PR pipeline as well and not only to the official build? It's always better to block these things in PR than after the merge. |
No, I will try to add it into PR pipeline |
|
What's the plan if this task is ever deprecated or breaks? |
|
If the task breaks, the official build would catch it, which means this is adding validation to that task that is currently not present until we hit the error in arcade-validation. If the task is deprecated we'll have to replace this with whatever we use to publish symbols, or it would be worth adding the extra test-only task. |
This was my recommendation in the original issue :) |
4338725 to
72c4a3b
Compare
|
I moved it into PR pipeline but it doesn't pass. I run locally to check the reason and it looks like PAT issue. I tried to replace it with |
|
@greenEkatherine I guess this one can be closed? |
It was on FR and I lost the context. No idea, sorry. |
|
Original issue was resolved by Jakub with a different PR, closing |
To double check:
Addressed #7509