Skip to content

Conversation

@jonfortescue
Copy link
Contributor

@jonfortescue jonfortescue commented Aug 3, 2021

I want to be able to create feeds in orgs outside of dnceng, and in order to do that I have to be able to specify this property, so the property can't be static. Changing things up to make that a possibility.

Additionally: allow specifying DryRun in PublishToSymbolServers.

To double check:

@jonfortescue
Copy link
Contributor Author

@chcosta Tested locally and functioning (creates the feeds successfully in both dnceng and dnceng-stage).

@jonfortescue
Copy link
Contributor Author

jonfortescue commented Aug 4, 2021

@riarenas @chcosta FYI: just added a parameter to PublishToSymbolServers to allow us to specify /p:DryRun

@riarenas
Copy link
Contributor

riarenas commented Aug 4, 2021

@riarenas @chcosta FYI: just added a parameter to PublishToSymbolServers to allow us to specify /p:DryRun

Seems odd to do it as part of this change, but #7708 which is in flight is making the same change so that's fine I think

@jonfortescue jonfortescue merged commit f7270e0 into dotnet:main Aug 4, 2021
@jonfortescue jonfortescue deleted the AllowOrgSpecificationCadof branch August 4, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants