Skip to content

Incorporate feedback on OneLocBuild doc #7522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonfortescue merged 6 commits into from
Jun 15, 2021
Merged

Incorporate feedback on OneLocBuild doc #7522

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
050a0fe
Incorporate feedback on OneLocBuild doc
jonfortescue Jun 14, 2021
77cfe6f
Line breaks
jonfortescue Jun 14, 2021
f28e07c
Update Documentation/OneLocBuild.md
jonfortescue Jun 14, 2021
a7b8d7e
Change up a bit
jonfortescue Jun 14, 2021
c61fc99
Merge branch 'FeedbackOnOneLocBuildDoc' of https://github.com/jonfort…
jonfortescue Jun 14, 2021
3687145
Add additional clarification
jonfortescue Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Documentation/OneLocBuild.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,16 @@ Onboarding to OneLocBuild is a simple process:
7. If using a mirrored repository (your code is mirrored to a trusted repository which your official build uses),
add the following parameter to your YAML (subbing e.g. `sdk` for the value):
```yaml
MirrorRepo: {{name of your GitHub repository}}
MirrorRepo: {{name of your GitHub repository, e.g. 'sdk'}}
Comment thread
This conversation was marked as resolved.
Outdated
```
This naming might be confusing for repositories using code mirroring through Maestro, as typically the
"mirror repository" refers to the trusted Azure DevOps repository our GitHub repositories mirror to.
In this case, however, it refers to the repository that _mirrors to_ the Azure DevOps repository
that the official build is based on.

As a further note, the template by default assumes that your mirror repository is located in the dotnet GitHub
organization. If that is not the case, you will need to specify `GitHubOrg` as well.

8. Merge the changes to your main branch and then open a
[repo modification ticket](https://ceapex.visualstudio.com/CEINTL/_workitems/create/Loc%20Request?templateId=415a0569-35ed-45c3-9321-8b1affff1f52&ownerId=c2e38d3d-0e9e-429f-955d-6e39fc6f0457)
with the loc team to let them know to retarget the branch.
Expand Down