Incorporate feedback on OneLocBuild doc #7522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvillalobos
approved these changes
Jun 14, 2021
Member
benvillalobos
left a comment
benvillalobos
left a comment
There was a problem hiding this comment.
The clarification helps a lot! Small suggestion for clarity, but good as is IMO
Co-authored-by: Ben Villalobos <[email protected]>
riarenas
reviewed
Jun 14, 2021
riarenas
approved these changes
Jun 14, 2021
garath
approved these changes
Jun 15, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some feedback from MSBuild folks on the doc so incorporating that here.
To double check: