Fix sdk-task invocation by not escaping manually #7508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Member
Author
|
Unrelated but we probably want to have CI validation for the sdk-task invocation in arcade. |
riarenas
approved these changes
Jun 10, 2021
Contributor
Agreed. I'll file something |
epananth
approved these changes
Jun 10, 2021
Contributor
|
As noticed, nothing here is exercised in CI, so abusing admin powers to expedite. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken official builds and avoid the revert in #7507.
Msbuild-task escaped the output path manually which conflicts with the escaping mechanism that I added to tools.ps1 in a419173.
To double check: