Skip to content

Conversation

@riarenas
Copy link
Contributor

@riarenas riarenas commented Jun 10, 2021

This reverts commit a419173.

fixes #7506

To double check:

@riarenas riarenas added the auto-merge Automatically merge PR once CI passes. label Jun 10, 2021
@ghost
Copy link

ghost commented Jun 10, 2021

Hello @riarenas!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ViktorHofer
Copy link
Member

I have the fix ready, if you give me another few minutes I can submit the PR.

@riarenas riarenas removed the auto-merge Automatically merge PR once CI passes. label Jun 10, 2021
@riarenas
Copy link
Contributor Author

@ViktorHofer sounds good. we can hold on on the revert:

@msftbot do not merge unless @ViktorHofer approves.

@riarenas
Copy link
Contributor Author

I'm not sure the auto merge bot understands it shouldn't merge this anymore, so closing for now.

@riarenas riarenas closed this Jun 10, 2021
ViktorHofer added a commit that referenced this pull request Jun 10, 2021
Fixes broken official builds and avoid the revert in #7507.

Msbuild-task escaped the output path manually which conflicted with the escaping mechanism that I added to tools.ps1 in a419173.
@ViktorHofer
Copy link
Member

PR is up: #7508

riarenas pushed a commit that referenced this pull request Jun 10, 2021
Fixes broken official builds and avoid the revert in #7507.

Msbuild-task escaped the output path manually which conflicted with the escaping mechanism that I added to tools.ps1 in a419173.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arcade official build and maestro publishing pipeline broken

4 participants