Skip to content

Fix symbol upload #7275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epananth merged 3 commits into from
Apr 22, 2021
Merged

Fix symbol upload #7275

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f542e45
fix symbol upload
epananth Apr 21, 2021
7813ecc
Updated log plus null check
epananth Apr 21, 2021
918dbfc
remove line chopping
epananth Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 52 additions & 43 deletions src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,57 +399,66 @@ public async Task PublishSymbolsUsingStreamingAsync(
Dictionary<string, string> serversToPublish =
GetTargetSymbolServers(feedConfigsForSymbols, msdlToken, symWebToken);

using (HttpClient client = CreateAzdoClient(AzureDevOpsOrg, true))
if (symbolsToPublish != null && symbolsToPublish.Any())
{
foreach (var symbol in symbolsToPublish)
using (HttpClient client = CreateAzdoClient(AzureDevOpsOrg, true))
{
string temporarySymbolsDirectory = CreateTemporaryDirectory();
string localSymbolPath = Path.Combine(temporarySymbolsDirectory, symbol);
symbolLog.AppendLine($"Downloading symbol : {symbol} to {localSymbolPath}");

await DownloadFileAsync(client, ArtifactName.BlobArtifacts, containerId, symbol, localSymbolPath);
symbolLog.AppendLine($"Successfully downloaded symbol : {symbol} to {localSymbolPath}");
List<string> symbolFiles = new List<string>();
symbolFiles.ToList().Add(localSymbolPath);

foreach (var server in serversToPublish)
foreach (var symbol in symbolsToPublish)
{
var serverPath = server.Key;
var token = server.Value;
symbolLog.AppendLine($"Publishing symbol file {symbol} to {serverPath}:");

try
{
await PublishSymbolsHelper.PublishAsync(
Log,
serverPath,
token,
symbolFiles,
null,
null,
ExpirationInDays,
false,
publishSpecialClrFiles,
null,
false,
false,
true);
}
catch (Exception ex)
string temporarySymbolsDirectory = CreateTemporaryDirectory();
string localSymbolPath = Path.Combine(temporarySymbolsDirectory, symbol);
symbolLog.AppendLine($"Downloading symbol : {symbol} to {localSymbolPath}");

await DownloadFileAsync(client, ArtifactName.BlobArtifacts, containerId, symbol, localSymbolPath);
symbolLog.AppendLine($"Successfully downloaded symbol : {symbol} to {localSymbolPath}");
List<string> symbolFiles = new List<string>();
symbolFiles.Add(localSymbolPath);
symbolLog.AppendLine($"Uploading symbol file '{string.Join(",", symbolFiles)}'");

foreach (var server in serversToPublish)
{
Log.LogError(ex.Message);
var serverPath = server.Key;
var token = server.Value;
symbolLog.AppendLine($"Publishing symbol file {symbol} to {serverPath}:");

try
{
await PublishSymbolsHelper.PublishAsync(
Log,
serverPath,
token,
symbolFiles,
null,
null,
ExpirationInDays,
false,
publishSpecialClrFiles,
null,
false,
false,
true);
}
catch (Exception ex)
{
Log.LogError(ex.Message);
}
}

DeleteTemporaryDirectory(temporarySymbolsDirectory);
}

DeleteTemporaryDirectory(temporarySymbolsDirectory);
symbolLog.AppendLine(
$"Performing symbol publishing... \nExpirationInDays : {ExpirationInDays} \nConvertPortablePdbsToWindowsPdb : false \ndryRun: false ");
symbolLog.AppendLine($"Total number of symbol files : {symbolsToPublish.Count}");
symbolLog.AppendLine("Successfully published to Symbol Server.");
symbolLog.AppendLine();
Log.LogMessage(MessageImportance.High, symbolLog.ToString());
symbolLog.Clear();
}
symbolLog.AppendLine(
$"Performing symbol publishing... \nExpirationInDays : {ExpirationInDays} \nConvertPortablePdbsToWindowsPdb : false \ndryRun: false ");
symbolLog.AppendLine($"Total number of symbol files : {symbolsToPublish.Count}");
symbolLog.AppendLine("Successfully published to Symbol Server.");
symbolLog.AppendLine();
Log.LogMessage(MessageImportance.High, symbolLog.ToString());
symbolLog.Clear();
}
else
{
Log.LogMessage(MessageImportance.High, $"No symbol files to upload.");
}

// publishing pdb artifacts
Expand Down