-
Notifications
You must be signed in to change notification settings - Fork 377
Fix symbol upload #7275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix symbol upload #7275
Conversation
|
A test would be useful to protect this from regressing again. |
|
I am adding some more test as a part of publishing here-> #7190 I will think of more test to cover symbol publishing as part of this exercise. |
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
missymessa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
|
verified it against general-testing-internal channel https://dnceng.visualstudio.com/internal/_build/results?buildId=1100514&view=results and @hoyosjs confirmed he can download the files. Symweb needs corpnet to download the files. |
|
thanks @epananth ! |

To double check:
Issue -> https://github.com/dotnet/core-eng/issues/12893
Test build -> https://dnceng.visualstudio.com/internal/_build/results?buildId=1100201&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=6e277ba4-1c1e-552d-b96f-db0aeb4be20a