Skip to content

Conversation

@epananth
Copy link
Member

@epananth epananth commented Apr 21, 2021

@ViktorHofer
Copy link
Member

A test would be useful to protect this from regressing again.

@epananth
Copy link
Member Author

I am adding some more test as a part of publishing here-> #7190 I will think of more test to cover symbol publishing as part of this exercise.

Copy link
Member

@missymessa missymessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

@epananth
Copy link
Member Author

verified it against general-testing-internal channel https://dnceng.visualstudio.com/internal/_build/results?buildId=1100514&view=results and @hoyosjs confirmed he can download the files.

Symweb needs corpnet to download the files.

@markwilkie
Copy link
Member

thanks @epananth !

@epananth epananth merged commit f6a518e into dotnet:main Apr 22, 2021
@epananth epananth deleted the fix-symbols branch April 23, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants