[ci] Add template for setting *JAVA_HOME vars #9671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Testing nightly here https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10820447&view=results |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ting against older JDK versions
jonathanpeppers
approved these changes
Jan 13, 2025
jpobst
approved these changes
Jan 13, 2025
jpobst
reviewed
Jan 13, 2025
| steps: | ||
| - pwsh: | | ||
| $agentOS="$(Agent.OS)" | ||
| $agentArch="$(Agent.OSArchitecture)" |
There was a problem hiding this comment.
There is likely a bug here because $(Agent.OSArchitecture) will be ARM64, the environment variable is JAVA_HOME_17_arm64, and environment variable names are case sensitive on Mac/Linux. But I can fix this in my ARM64 PR since I can test it easier.
grendello
added a commit
that referenced
this pull request
Jan 14, 2025
* main: [ci] Add template for setting JAVA_HOME vars (#9671) Bump com.android.tools.build:manifest-merger from 31.7.3 to 31.8.0 (#9678) Bump to dotnet/sdk@2dd591056f 10.0.100-alpha.1.25062.16 (#9679) Bump com.android.tools:r8 from 8.5.35 to 8.7.18 (#9677) Bump to dotnet/java-interop@4f06201 (#9676) Bump to dotnet/android-api-docs@492e524d (#9668) [build] Support JDK-21 (#9672)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
setup-jdk-variables.yamltemplate to set theJAVA_HOMEandJI_JAVA_HOMEvariables from a single script location.A new
JI_JAVA_HOME_DEFAULTvariable will also be set to point to acurrent JDK that can be used to run various Android SDK tools as needed.
Consolidating this logic should make it easier to update the default
JDK version we install and/or test against in the future.
Build jobs and some test jobs that run on custom agents will use the
default android-toolchain path that xaprepare installs into.
Most other test jobs will attempt to use the value of a preinstalled JDK
found at
$JAVA_HOME_$(JAVA_VERSION)_$(OS_ARCH)if it is defined.