Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Run Mac MSBuild tests on macos-14-arm64 #9665

Merged
merged 5 commits into from
Jan 15, 2025
Merged

[ci] Run Mac MSBuild tests on macos-14-arm64 #9665

merged 5 commits into from
Jan 15, 2025

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Jan 9, 2025

Azure Pipelines now provides the macos-14-arm64 image. We can use this image to run our MSBuild tests on. This is a benefit because it's nearly twice as fast and nowadays our Mac users are probably more likely to be running arm64.

Unfortunately it does not support nested virtualization, so we can't run our emulator tests on this image. Supposedly Apple added nested virtualization in MacOS 15, but Azure does not have macos-15-arm64 images yet. Hopefully we will be able to use those for emulator tests in the future.

Additionally:

  • Update apkdiff to a newer version with Apple Silicon support.
  • Tweak agent count since we now need fewer Mac agents, but could use a couple more Windows agents.
  • Bugfix to make sure we're using the right JDK path for ARM64.

@jpobst jpobst force-pushed the macos-14-arm64 branch 7 times, most recently from 4f4b189 to 8b363ea Compare January 9, 2025 23:03
@jpobst
Copy link
Contributor Author

jpobst commented Jan 10, 2025

@pjcollins Do you know of a more elegant way to appropriately set JI_JAVA_HOME? My current solution is pretty clunky, and will also fail for the nightly JDK-11 test, which specifies $(JAVA_HOME_11_X64).

@pjcollins
Copy link
Member

@pjcollins Do you know of a more elegant way to appropriately set JI_JAVA_HOME? My current solution is pretty clunky, and will also fail for the nightly JDK-11 test, which specifies $(JAVA_HOME_11_X64).

I'm trying to consolidate the places we use these Azure pipelines hosted agent JAVA_HOME vars in #9671 to simplify a future bump to JDK 21, and will try to make sure the arch component of the variable name is considered there.

@jpobst jpobst changed the title [ci] Run tests on macos-14-arm64 [ci] Run MSBuild tests on macos-14-arm64 Jan 13, 2025
@jpobst jpobst force-pushed the macos-14-arm64 branch 2 times, most recently from 9febc43 to 570e018 Compare January 14, 2025 18:51
@dotnet dotnet deleted a comment from azure-pipelines bot Jan 14, 2025
@dotnet dotnet deleted a comment from azure-pipelines bot Jan 14, 2025
@jpobst jpobst changed the title [ci] Run MSBuild tests on macos-14-arm64 [ci] Run Mac MSBuild tests on macos-14-arm64 Jan 14, 2025
@jpobst jpobst marked this pull request as ready for review January 15, 2025 01:18
@jpobst jpobst merged commit db357c7 into main Jan 15, 2025
57 of 59 checks passed
@jpobst jpobst deleted the macos-14-arm64 branch January 15, 2025 17:17
grendello added a commit that referenced this pull request Jan 16, 2025
* main:
  [ci] Run Mac MSBuild tests on `macos-14-arm64` (#9665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants