Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xamarin.Android.Build.Tasks] move Console.WriteLine() messages to MSBuild log #9359

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[Xamarin.Android.Build.Tasks] move Console.WriteLine() messages to MSBuild log #9359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Xamarin.Android.Build.Tasks/Utilities/AssemblyStoreGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,15 +149,15 @@ string Generate (string baseOutputDirectory, AndroidTargetArch arch, List<Assemb
WriteIndex (writer, mw, index, descriptors, is64Bit);
mw.Flush ();

Console.WriteLine ($"Number of descriptors: {descriptors.Count}; index entries: {index.Count}");
Console.WriteLine ($"Header size: {AssemblyStoreHeader.NativeSize}; index entry size: {IndexEntrySize ()}; descriptor size: {AssemblyStoreEntryDescriptor.NativeSize}");
log.LogDebugMessage ($"Number of descriptors: {descriptors.Count}; index entries: {index.Count}");
log.LogDebugMessage ($"Header size: {AssemblyStoreHeader.NativeSize}; index entry size: {IndexEntrySize ()}; descriptor size: {AssemblyStoreEntryDescriptor.NativeSize}");

WriteDescriptors (writer, descriptors);
WriteNames (writer, infos);
writer.Flush ();

if (fs.Position != (long)assemblyDataStart) {
Console.WriteLine ($"fs.Position == {fs.Position}; assemblyDataStart == {assemblyDataStart}");
log.LogDebugMessage ($"fs.Position == {fs.Position}; assemblyDataStart == {assemblyDataStart}");
throw new InvalidOperationException ($"Internal error: store '{storePath}' position is different than metadata size after header write");
}

Expand Down
Loading