[Xamarin.Android.Build.Tasks] move Console.WriteLine() messages to MSBuild log
#9359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MSBuild log
When running builds at the command-line (with the default, new
"MSBuild Terminal Logger"), `Console.WriteLine()` output can make the
text not look so great:
> dotnet build -c Release -bl
Restore complete (0.6s)
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
hellomaui _BuildApkEmbed (18.9s)
Number of descriptors: 116; index entries: 232
hellomaui succeeded (33.3s) → bin\Release\net9.0-android\android-arm64\hellomaui.dll
Build succeeded in 46.8s
The message `Number of descriptors: 116; index entries: 232` appears,
but so does another one. You can watch the terminal logger clear and
rewrite messages, which is not ideal.
Let's move these to the MSBuild logger, so they will show up in
`.binlog` files, but not in the console output.
grendello
approved these changes
Oct 2, 2024
jonathanpeppers
added a commit
that referenced
this pull request
Oct 2, 2024
…MSBuild log (#9359) When running builds at the command-line (with the default, new "MSBuild Terminal Logger"), `Console.WriteLine()` output can make the text not look so great: > dotnet build -c Release -bl Restore complete (0.6s) You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy hellomaui _BuildApkEmbed (18.9s) Number of descriptors: 116; index entries: 232 hellomaui succeeded (33.3s) → bin\Release\net9.0-android\android-arm64\hellomaui.dll Build succeeded in 46.8s The message `Number of descriptors: 116; index entries: 232` appears, but so does another one. You can watch the terminal logger clear and rewrite messages, which is not ideal. Let's move these to the MSBuild logger, so they will show up in `.binlog` files, but not in the console output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running builds at the command-line (with the default, new "MSBuild Terminal Logger"),
Console.WriteLine()output can make the text not look so great:The message
Number of descriptors: 116; index entries: 232appears, but so does another one. You can watch the terminal logger clear and rewrite messages, which is not ideal.Let's move these to the MSBuild logger, so they will show up in
.binlogfiles, but not in the console output.