Skip to content

Fix | Write DateOnly instances to sql_variant columns of table-valued parameters as date values - #4439

Merged
priyankatiwari08 merged 3 commits into
dotnet:mainfrom
edwardneal:fix/dateonly-tvp-variant
Aug 24, 2026
Merged

priyankatiwari08 merged 3 commits into
dotnet:mainfrom
edwardneal:fix/dateonly-tvp-variant

Code review - style nit

226969c
Select commit
Loading
Failed to load commit list.
Azure Pipelines / sqlclient-pr succeeded Aug 14, 2026 in 23m 32s

Build #20816 had test failures

Details

Tests

  • Failed: 1 (0.00%)
  • Passed: 30,228 (86.95%)
  • Other: 4,534 (13.04%)
  • Total: 34,763

Annotations

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.MARSTest.MarsConcurrencyTest

See this annotation in the file changed.

@azure-pipelines azure-pipelines / sqlclient-pr

Microsoft.Data.SqlClient.ManualTesting.Tests.MARSTest.MarsConcurrencyTest

CRITIAL: Test should not fail randomly. Exception occurred: One or more errors occurred. (ExecuteReader requires an open and available Connection. The connection's current state is open.) (ExecuteReader requires an open and available Connection. The connection's current state is open.) (ExecuteReader requires an open and available Connection. The connection's current state is open.) (ExecuteReader requires an open and available Connection. The connection's current state is open.) (ExecuteReader requires an open and available Connection. The connection's current state is open.) (ExecuteReader requires an open and available Connection. The connection's current state is open.) (ExecuteReader requires an open and available Connection. The connection's current state is open.) (ExecuteReader requires an open and available Connection. The connection's current state is open.) (The connection is broken and recovery is not possible.  The connection is marked by the client driver as unrecoverable.  No attempt was made to restore the connection.)
Raw output
   at Microsoft.Data.SqlClient.ManualTesting.Tests.MARSTest.MarsConcurrencyTest() in /mnt/vss/_work/1/s/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/MARSTest/MARSTest.cs:line 696
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)