Skip to content

Fix | Write DateOnly instances to sql_variant columns of table-valued parameters as date values - #4439

Merged
priyankatiwari08 merged 3 commits into
dotnet:mainfrom
edwardneal:fix/dateonly-tvp-variant
Aug 24, 2026
Merged

priyankatiwari08 merged 3 commits into
dotnet:mainfrom
edwardneal:fix/dateonly-tvp-variant

Code review - style nit

226969c
Select commit
Loading
Failed to load commit list.
Azure Pipelines / PR-SqlClient-Package succeeded Jul 27, 2026 in 3h 18m 36s

Build #20816 had test failures

Details

Tests

  • Failed: 12 (0.00%)
  • Passed: 297,549 (97.51%)
  • Other: 7,580 (2.48%)
  • Total: 305,141

Annotations

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

EXEC#L0

EXEC(0,0): Error Message: 

Check failure on line 717 in build.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

build.proj#L717

build.proj(717,5): Error MSB3073: The command " "dotnet" test "/mnt/vss/_work/1/s/src/../src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj" -p:Configuration=Debug --blame-hang --blame-hang-dump-type full --blame-hang-timeout 10m --filter "category=flaky&(Set=3)" -f net9.0 --results-directory "TestResults" --logger:"trx;LogFilePrefix=SqlClientManual-Unix-net9.0-3" -p:ReferenceType=Package -p:AbstractionsPackageVersion=7.1.0-preview2ci20816 -p:LoggingPackageVersion=7.1.0-preview2ci20816 -p:SqlClientPackageVersion=7.1.0-preview2ci20816 -p:SqlServerPackageVersion=1.1.0-preview1ci20816 " exited with code 1.

Check failure on line 57 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Build log #L57

Error: The process '/opt/hostedtoolcache/dotnet/dotnet' failed with exit code 1

Check failure on line 60 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Build log #L60

Dotnet command failed with non-zero exit code on the following projects : [ '/mnt/vss/_work/1/s/build.proj' ]

Check failure on line 1 in Microsoft.Data.SqlClient.UnitTests.SimulatedServerTests.ConnectionFailoverTests.TransientFault_WithUserProvidedPartner_Pooling_ShouldNotClearPool_NotFailover(errorCode: 42109)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.UnitTests.SimulatedServerTests.ConnectionFailoverTests.TransientFault_WithUserProvidedPartner_Pooling_ShouldNotClearPool_NotFailover(errorCode: 42109)

Assert.Equal() Failure: Strings differ
                         ↓ (pos 14)
Expected: "localhost,64538"
Actual:   "localhost,64537"
                         ↑ (pos 14)
Raw output
   at Microsoft.Data.SqlClient.UnitTests.SimulatedServerTests.ConnectionFailoverTests.TransientFault_WithUserProvidedPartner_Pooling_ShouldNotClearPool_NotFailover(UInt32 errorCode) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\UnitTests\SimulatedServerTests\ConnectionFailoverTests.cs:line 817

Check failure on line 1 in Microsoft.Data.SqlClient.UnitTests.SimulatedServerTests.ConnectionFailoverTests.TransientFault_WithUserProvidedPartner_Pooling_ShouldNotClearPool_NotFailover(errorCode: 42109)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.UnitTests.SimulatedServerTests.ConnectionFailoverTests.TransientFault_WithUserProvidedPartner_Pooling_ShouldNotClearPool_NotFailover(errorCode: 42109)

Assert.Equal() Failure: Strings differ
                         ↓ (pos 14)
Expected: "localhost,51132"
Actual:   "localhost,51131"
                         ↑ (pos 14)
Raw output
   at Microsoft.Data.SqlClient.UnitTests.SimulatedServerTests.ConnectionFailoverTests.TransientFault_WithUserProvidedPartner_Pooling_ShouldNotClearPool_NotFailover(UInt32 errorCode) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\UnitTests\SimulatedServerTests\ConnectionFailoverTests.cs:line 817

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.TvpQueryHintsTests.DefaultColumnAll

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.TvpQueryHintsTests.DefaultColumnAll

Microsoft.Data.SqlClient.SqlException : Execution Timeout Expired.  The timeout period elapsed prior to completion of the operation or the server is not responding.
Operation cancelled by user.
---- System.ComponentModel.Win32Exception : The wait operation timed out.
Raw output
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean isAsync, Int32 timeout, Boolean asyncWrite)
   at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean isRetry, String methodName)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.TvpQueryHintsTests.Dispose() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\TvpQueryHintsTests.cs:line 58
   at ReflectionAbstractionExtensions.DisposeTestClass(ITest test, Object testClass, IMessageBus messageBus, ExecutionTimer timer, CancellationTokenSource cancellationTokenSource) in /_/src/xunit.execution/Extensions/ReflectionAbstractionExtensions.cs:line 79
----- Inner Stack Trace -----

Check failure on line 1 in Microsoft.Data.SqlClient.UnitTests.SimulatedServerTests.ConnectionFailoverTests.TransientFault_WithUserProvidedPartner_Pooling_ShouldNotClearPool_NotFailover(errorCode: 42109)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.UnitTests.SimulatedServerTests.ConnectionFailoverTests.TransientFault_WithUserProvidedPartner_Pooling_ShouldNotClearPool_NotFailover(errorCode: 42109)

Assert.Equal() Failure: Strings differ
                         ↓ (pos 14)
Expected: "localhost,60701"
Actual:   "localhost,60700"
                         ↑ (pos 14)
Raw output
   at Microsoft.Data.SqlClient.UnitTests.SimulatedServerTests.ConnectionFailoverTests.TransientFault_WithUserProvidedPartner_Pooling_ShouldNotClearPool_NotFailover(UInt32 errorCode) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\UnitTests\SimulatedServerTests\ConnectionFailoverTests.cs:line 817
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)