Improvements to value generation docs #2998
Conversation
roji
force-pushed
the
GeneratedProperties
branch
4 times, most recently
from
60a5403 to
701e492
Compare
| "MD024": { | ||
| "allow_different_nesting": true | ||
| }, | ||
| "MD024": false, |
There was a problem hiding this comment.
Dotnet/docs uses individual <!-- markdownlint disable MD024--> statements when the old tab format causes issues instead of turning off rules entirely
There was a problem hiding this comment.
Is there an alternative new tab format the we can use instead, that doesn't have this problem?
If not, forcing these linter suppression in the doc codes seems to me more annoying/ugly than the value that MD024 brings, though that's subjective...
There was a problem hiding this comment.
I think there was supposed to be a ::: version at some point awhile ago, but I think most of the docs for that type of thing is in the https://review.docs.microsoft.com/ site that isn't available to the public
| [!code-csharp[Main](../../../samples/core/Modeling/FluentAPI/ComputedColumn.cs?name=StoredComputedColumn)] | ||
| ## Overriding value generation | ||
|
|
||
| Although a property is configured for value generation, in many cases you may still explicitly specify a value for it. Whether this will actually work depends on the specific value generation mechanism that has been configured; while you may specify an explicit value instead of using a column's default value, the same cannot be done with computed columns. |
There was a problem hiding this comment.
This may be a bit light, compared to the "Setting Explicit Values for Generated Properties" page which this PR removes (though note that some of its content went into the SQL Server docs). It seems reasonable to me, but would accept opinions to the contrary.
|
|
||
| To provide an explicit value for properties that have been configured as value generated on add or update, you must also configure the property as follows: | ||
|
|
||
| [!code-csharp[Main](../../../samples/core/Modeling/FluentAPI/ValueGeneratedOnAddOrUpdateWithPropertySaveBehavior.cs?name=ValueGeneratedOnAddOrUpdateWithPropertySaveBehavior&highlight=5)] |
There was a problem hiding this comment.
Note that the original section in "Setting Explicit Values for Generated Properties" said to use PropertySaveBehavior.Ignore which didn't work for me - PropertySaveBehavior.Save does. Also, no exception was thrown when specifying Ignore (which is what the text said).
One last thing, when the property ValueGeneratedOnAddOrUpdate(), then overriding with explicit values works when updating (with PropertySaveBehavior.Save), but doesn't seem to work when adding...
There was a problem hiding this comment.
Opened dotnet/efcore#23912 to track the apparent adding bug.
* Create new page on SQL Server value generation, with information on IDENTITY, seed/increment, etc. * Delete "explicit values for generated properties" page, moving relevant content to the new SQL Server page and to the fixed-up generated properties page. Closes #2999
Co-authored-by: Andriy Svyryd <[email protected]>
Co-authored-by: Andriy Svyryd <[email protected]>
roji
force-pushed
the
GeneratedProperties
branch
from
4a64261 to
01d7cb4
Compare
This ended up rabbit-holing into bigger change than just #2980. @AndriySvyryd let me know what you think.
Fixes #2980
Fixes #2947
Closes #2999