AfterSaveBehavior default is actually .Ignore, not .Throw

[dbrownems]

Updating docs to match actual behavior of AfterSaveBehavior, and to clarify treatment of database-side changes in case of .Save and .Ignore

[Rick-Anderson]

@dbrownems can you check my changes? Avoid future tense and split up long sentences.

[ajcvickers]

@Rick-Anderson The reason this isn't merged is that I still need to investigate the technical aspects of this.

[smitpatel]

@ajcvickers - Also include changes from #2372 depending on the decision.

[dnfadmin]

All CLA requirements met.

[Rick-Anderson]

@ajcvickers - Also include changes from #2372 depending on the decision.

@smitpatel I added it.

[dbrownems]

looks good

[Rick-Anderson]

@dbrownems thanks for the review. When I added your other commit to this PR it pushed you over the limit to require a signed CLA to accept the PR. Would you mind signing that?

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ dbrownems sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[ajcvickers]

@roji Is this obsolete now that you updated these pages? Also, did you check the behavior to make sure the docs are correct?

[roji]

Yeah, this has been corrected in #2998 - one needs to do SetAfterSaveBehavior(PropertySaveBehavior.Save) in order to provide explicit values for properties configured as OnAddOrUpdate. The default is Ignore for OnUpdate properties, which makes explicit values ignored, whereas Save makes them properly sent to the database. I've just tested this again and it works this way.

• I'm new to this area, but I wonder - is there any reason for Ignore to be the default for on-update-generated properties? Doesn't this just make them non-overridable by default, is there any reason not to return Save here instead?
• FWIW the XML docs on SetAfterSaveBehavior seem unclear on all this - they discuss what happens "whether this property can be modified after the entity is saved to the database", but at least in this case it's more about whether the user-set value is sent to the database or not.
• Opened Can't add explicit value when adding for a property with AfterSaveBehavior=Save efcore#23912 for what seems to be a bug when using explicit values when adding the entity.