Update Query documentation #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/query
branch
5 times, most recently
from
1a85f8e
to
7fae285
Compare
AndriySvyryd
reviewed
Oct 3, 2019
AndriySvyryd
reviewed
Oct 3, 2019
bricelam
reviewed
Oct 3, 2019
|
Updated. |
roji
previously requested changes
Oct 4, 2019
|
@smitpatel FYI am going to stop reviewing the responses to my PR, as 95% seem to be simple rejections with no explanation. |
|
@roji - I incorporated the suggestions just not as is because acrolinx complained about it. I have taken ideas from the suggestion to update the text to simplify it. The outdated items above and if you read the docs, I have updated the content. By no means I feel obligated to take all the suggestions as is. cc: @ajcvickers @bricelam |
bricelam
approved these changes
Oct 4, 2019
Resolves#615 Resolves#1636 Resolves#1648 Resolves#1699 Resolves#1777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves#615
Resolves#1636
Resolves#1648
Resolves#1699
Resolves#1777