Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client eval page for 3.0 #1648

Closed
divega opened this issue Aug 18, 2019 — with docs.microsoft.com · 4 comments · Fixed by #1799
Closed

Update client eval page for 3.0 #1648

divega opened this issue Aug 18, 2019 — with docs.microsoft.com · 4 comments · Fixed by #1799

Comments

Copy link
Contributor

divega commented Aug 18, 2019

Points to cover:

  1. EF Core 3.0 does very limited client eval
  2. Explicitly switching to client eval can be done, for example, with AsEnumerable, AsAsyncEnumerable, ToList, ToListAsync. Each has trade-offs.

Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@ajcvickers ajcvickers added this to the Backlog milestone Sep 2, 2019
@ajcvickers ajcvickers assigned roji, bricelam and smitpatel and unassigned roji Sep 6, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 3.0.0 Sep 6, 2019
@bricelam bricelam removed their assignment Sep 17, 2019
smitpatel referenced this issue Oct 3, 2019
Resolves#615
Resolves#1636
Resolves#1648
Resolves#1699
Resolves#1777
smitpatel referenced this issue Oct 3, 2019
Resolves#615
Resolves#1636
Resolves#1648
Resolves#1699
Resolves#1777
smitpatel referenced this issue Oct 3, 2019
Resolves#615
Resolves#1636
Resolves#1648
Resolves#1699
Resolves#1777
smitpatel referenced this issue Oct 3, 2019
Resolves#615
Resolves#1636
Resolves#1648
Resolves#1699
Resolves#1777
smitpatel referenced this issue Oct 3, 2019
Resolves#615
Resolves#1636
Resolves#1648
Resolves#1699
Resolves#1777
smitpatel referenced this issue Oct 3, 2019
Resolves#615
Resolves#1636
Resolves#1648
Resolves#1699
Resolves#1777
smitpatel referenced this issue Oct 3, 2019
Resolves#615
Resolves#1636
Resolves#1648
Resolves#1699
Resolves#1777
@smitpatel
Copy link
Member

I updated to add AsEnumerable/AsAsyncEnumerable. Does anyone know any benefits of ToList/ToListAsync?

@AndriySvyryd
Copy link
Member

No multiple evaluation when used again?

@roji
Copy link
Member

roji commented Oct 4, 2019

Right, though I see people also doing ToList/ToListAsync even when enumerating only once, which is an anti-pattern (needless memory for buffering). We should ideally explain these nuances.

smitpatel referenced this issue Oct 4, 2019
Resolves#615
Resolves#1636
Resolves#1648
Resolves#1699
Resolves#1777
smitpatel referenced this issue Oct 5, 2019
Resolves#615
Resolves#1636
Resolves#1648
Resolves#1699
Resolves#1777
smitpatel referenced this issue Oct 7, 2019
Resolves#615
Resolves#1636
Resolves#1648
Resolves#1699
Resolves#1777
Copy link

ygoe commented Nov 9, 2019

ToList also fetches the data immediately. This may be necessary if the underlying cursor cannot stay open while doing other queries on the same connection, or if the enumeration being iterated will be changed (less relevant for database queries).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants