Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow regression metrics to work with significance=None #7

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions nonconformist/evaluation.py
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ def reg_n_correct(prediction, y, significance=None):
return y[correct].size


def reg_mean_errors(prediction, y, significance):
def reg_mean_errors(prediction, y, significance=None):
"""Calculates the average error rate of a conformal regression model.
"""
return 1 - reg_n_correct(prediction, y, significance) / y.size
Expand Down Expand Up @@ -378,34 +378,35 @@ class ``c``. Use ``functools.partial`` in order to test other classes.
# -----------------------------------------------------------------------------
# Efficiency measures
# -----------------------------------------------------------------------------
def _reg_interval_size(prediction, y, significance):
idx = int(significance * 100 - 1)
prediction = prediction[:, :, idx]
def _reg_interval_size(prediction, y, significance=None):
if significance is not None:
idx = int(significance * 100 - 1)
prediction = prediction[:, :, idx]

return prediction[:, 1] - prediction[:, 0]


def reg_min_size(prediction, y, significance):
def reg_min_size(prediction, y, significance=None):
return np.min(_reg_interval_size(prediction, y, significance))


def reg_q1_size(prediction, y, significance):
def reg_q1_size(prediction, y, significance=None):
return np.percentile(_reg_interval_size(prediction, y, significance), 25)


def reg_median_size(prediction, y, significance):
def reg_median_size(prediction, y, significance=None):
return np.median(_reg_interval_size(prediction, y, significance))


def reg_q3_size(prediction, y, significance):
def reg_q3_size(prediction, y, significance=None):
return np.percentile(_reg_interval_size(prediction, y, significance), 75)


def reg_max_size(prediction, y, significance):
def reg_max_size(prediction, y, significance=None):
return np.max(_reg_interval_size(prediction, y, significance))


def reg_mean_size(prediction, y, significance):
def reg_mean_size(prediction, y, significance=None):
"""Calculates the average prediction interval size of a conformal
regression model.
"""
Expand Down