Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow regression metrics to work with significance=None #7

Closed

Conversation

jb-delafosse
Copy link

Reference Issue

See issue #6

What does this implement/fix? Explain your changes.

I added the default value None to various evaluation function for regression only

I think the same thing could be done for classification problems

@donlnz
Copy link
Owner

donlnz commented Jun 12, 2017

Thanks for the suggestion.

I agree that the evaluation metrics could support significance=None (thus evaluating validity/efficiency at all significance levels simultaneously). However, I find that there are some problems with your submitted patch: reg_mean_size, reg_median_size, etc should return (if significance=None), the mean, median (etc) size per significance level. Currently, they return the mean, median (etc) over all significance levels, which does not seem reasonable to me.

I also agree that a similar approach could be taken to classification evaluation metrics.

I'll see if I can get around to fixing these in the next few weeks. Otherwise, feel free to submit a new patch that solves the issues mentioned.

@donlnz donlnz closed this Jun 12, 2017
@jb-delafosse
Copy link
Author

Ok. I see where I was wrong. I'm using only one significance level (95%) and hence it does what I want.

I need to make sure it works correctly when multiple significance levels are used.

Am I correct ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants