Skip to content

Fix formatting hex float literals #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domluna merged 2 commits into from
Nov 25, 2025
Merged

Fix formatting hex float literals #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cfbe35
Fix formatting hex float literals
mhauru Nov 21, 2025
a6473f8
Add a clarifying comment
mhauru Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/styles/default/pretty.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ function p_literal(
val = getsrcval(s.doc, s.offset:(s.offset+span(cst)-1))

if !is_str_or_cmd(cst)
if kind(cst) in KSet"Float Float32" && !startswith(val, "0x")
if kind(cst) in KSet"Float Float32" && !startswith(val, r"[+-]?0x")
float_suffix = if (fidx = findlast(==('f'), val)) === nothing
""
else
Expand Down
11 changes: 11 additions & 0 deletions test/issues.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1953,4 +1953,15 @@
sf = "using Foo: (..)"
@test fmt(s, 4, 100) == sf
end

@testset "921" begin
# These are floating point literals with hexadecimal significands. E.g. 0x1p1 is the
# float with with 0x1 as the significant and 1 as the exponent.
s = "0x1p1"
@test fmt(s) == s
s = "+0x1p1"
@test fmt(s) == s
s = "-0x1p1"
@test fmt(s) == s
end
end
Loading