Fix formatting hex float literals #954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #921
There's still this case, where the formatter changes the value of the expression:
However, I think
0x1p1.2should be a syntax error, so maybe not worth fixing? I've reported it as a Julia bug here JuliaLang/julia#60189. To be clear, what happens there is that Julia parses0x1p1.2as a juxtaposition of0x1p1and.2, i.e. a multiplication. The formatter then expands the .2 to be 0.2, which results in0x1p10.2, changing the value of the first literal that is being multiplied.