Skip to content

Conversation

@martincostello
Copy link
Collaborator

@martincostello martincostello commented Jul 4, 2025

Update to the ASP.NET Core .NET 10 preview.6 and Microsoft.OpenApi 2.0.0-preview.29.

Notable changes

  • Simplification of various namespaces to simply Microsoft.OpenApi.
  • Interfaces reintroduced to various properties which simplifies the sorting, but breaks the ability to use collection expressions in a number of places.
  • Some API diffs caused by ordering are reverted by serialization updates, so the diff post-merge should get smaller compared to the default branch again.

Needs updating to the official build, rather than a nightly, before merge.

@martincostello martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Jul 4, 2025
@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.75%. Comparing base (c8e5aef) to head (080672c).
Report is 1 commits behind head on dotnet-vnext.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##           dotnet-vnext    #3479      +/-   ##
================================================
+ Coverage         94.70%   94.75%   +0.05%     
================================================
  Files               110      110              
  Lines              3850     3830      -20     
  Branches            773      758      -15     
================================================
- Hits               3646     3629      -17     
+ Misses              204      201       -3     
Flag Coverage Δ
Linux 94.75% <100.00%> (+0.05%) ⬆️
Windows 94.75% <100.00%> (+0.05%) ⬆️
macOS 94.75% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello force-pushed the dotnet-10-preview.6 branch 5 times, most recently from 75dca2d to c51b906 Compare July 8, 2025 15:53
Update to the latest nightly build of .NET 10 preview 6 to prepare for bump to Microsoft.OpenApi 2.0.0-preview.29.
@martincostello martincostello mentioned this pull request Jul 13, 2025
13 tasks
Bump versions for public release of preview 6.
@martincostello martincostello marked this pull request as ready for review July 15, 2025 14:33
Copilot AI review requested due to automatic review settings July 15, 2025 14:33
@martincostello martincostello merged commit c2bb204 into dotnet-vnext Jul 15, 2025
12 of 15 checks passed
@martincostello martincostello deleted the dotnet-10-preview.6 branch July 15, 2025 14:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to ASP.NET Core 10 preview.6 and Microsoft.OpenApi 2.0.0-preview.29, simplifying various Microsoft.OpenApi namespaces to use the unified Microsoft.OpenApi namespace as per the notable changes mentioned in the description.

  • Updates package references from preview.5 to preview.6
  • Simplifies Microsoft.OpenApi namespace imports
  • Adapts to breaking changes in the OpenApi library including loss of collection expressions support

Reviewed Changes

Copilot reviewed 146 out of 146 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Directory.Packages.props Updates Microsoft.OpenApi packages to preview.29 and AspNetCore.OpenApi to preview.6
global.json Updates .NET SDK version to 10.0.100-preview.6
src/Swashbuckle.AspNetCore.SwaggerGen/SwaggerGenerator/SwaggerGenerator.cs Simplifies OpenApi namespace imports and removes collection expressions
test/WebSites/TestFirst.IntegrationTests/CreateUserTests.cs Replaces collection expression with explicit SortedSet instantiation
Multiple test and source files Simplifies OpenApi namespace imports from specific Models/Interfaces to unified namespace

martincostello added a commit that referenced this pull request Nov 11, 2025
* Support .NET 10

- Add support for ASP.NET Core 10 and Microsoft.OpenApi v2.
- Add opt-in support for OpenAPI 3.1 when targeting `net10.0`.

* Fix test

Fix broken test.

* Remove obsolete method

Remove obsolete method.

* Update to ASP.NET Core 10 preview 2

Update to preview 2 of ASP.NET Core 10, which includes Microsoft.OpenApi 2.0.0-preview7.

* Add TODO

Add TODO to use `SerializeAs()`.

* Partially fix security requirement issue

Use `AddComponent()` to ensure references work correctly.

* Fix test

Fix test by passing the current `OpenApiDocument` to the filter contexts so it can be used to resolve the references.

* Fix test

Fix broken test.

* Fix type tests

Account for flags enum.

* Fix missing descriptions

Fix missing descriptions in .NET 10.

* Refactor fix

Restore the sample projects to how they were, and instead adjust the annotation filters to consider parameters and properties for records.

* Fix package reference

Fix missed rename in merge.

* Fix xUnit1051 warnings

Fix xUnit1051 warnings

* Update to ASP.NET Core 10 preview 3 (#3361)

Update to preview 3 of ASP.NET Core 10.

* Update NuGet packages

Update NuGet packages for .NET 10 preview 3.

* Link to issue

Update Skip with link to GitHub issue.

* Fix typo

"respository" ➡️ "repository".

* Fix tag serialization

Add tags to the document before adding them to the operations as a workaround for microsoft/OpenAPI.NET#2319.

* Fix merge

Fix bad merge with default branch.

* Add issue reference

Add comment with link to issue.

* Remove TODO

Based on tests passing, I think it is correct.

* Fix formatting

Adjust formatting to match what it would be without the pragma.

* Prepare for .NET 10 preview 4 (#3388)

Cherry-pick changes from #3386 to prepare for ASP.NET Core 10 preview 4 and Microsoft.OpenApi 2.0.0-preview.17.

* Fix nullability for null schema Type

Fix bitmasks for adding `JsonSchemaType.Null` if the `Type` is null.

Resolves #3387.

* Re-enable MyGet

Re-enable MyGet on the off-chance that it was a transient issue and has self-resolved.

* Fix rebase

Fix changes after merge from main.

* Skip failing tets

Skip failing tests for now - re-visit once ASP.NET Core 10 preview.4 lets us update to Microsoft.OpenApi 2.0.0-preview.17.

* Update MyGet publish URL

See if the issue is specific to the old V2 push endpoint.

* Re-disable MyGet publishing

Using the v3 feed didn't fix it.

* Update to Microsoft.OpenApi 2.0.0 preview 17

Update Microsoft.OpenApi to version 2.0.0-preview.17 using the latest daily build of ASP.NET Core 10 preview 4.

* Fix API baselines

Update API baselines for change from `OperationType` to `HttpMethod `.

* Skip failing tests

.NET 8 and 9 TestFirst integration tests are failing, so skip for now.

* Use SerializeAs

Use the new `SerializeAs()` method to resolve TODOs.

* Fix build

Use the right writer.

* Apply suggestions from code review

* Fix build

Fix build for official build of .NET 10 preview 4.

* Disable failing tests

Disable tests failing due to yet-to-be-logged issue with the OpenAPI document being truncated/not flushed.

* Fix MergeWith

Fix incorrect file name.

* Publish packages

Publish NuGet packages to the workflow even if tests fail.

* Fix tests

Fix tests due to error in test setup fixture caused by changes in microsoft/OpenAPI.NET#2325.

* Remove workaround

Remove workaround needed for previous preview versions.

* Re-enable tests

Re-enable three skipped tests that are no longer failing.

* Re-enable MyGet publishing

Re-enable publishing to MyGet.

* Apply review suggestions

Apply some of the code-review suggestions. More to follow.

* Workaround VS issue

Workaround issue building the solution in Visual Studio.

* Fix culture-insensitive handling of numbers with [Range] (#3426)

Fix incorrect handling of culture-sensitivity for number ranges.

* Refactor method

Rename constant and move culture to variable.

* Fix range parsing

- Use the correct culture to parse `[Range]`.
- Update snapshots.

* Sort AnyOf and OneOf

Address code review comment.

* Update issue number

Point to latest issue number.

* Refactor [Range] handling

Refactor how `[Range]` is handled to match how ASP.NET Core 10 does.

* Add test cases for `[Range]`

Add various test cases for the behaviour of `[Range]` applying changes to `OpenApiSchema` instances.

* Refactor method to avoid round-trip

Refactor method to avoid redundant round-trip parse/format when the `Maximum` and `Minimum` properties are not strings.

* Tweak comment

Fix grammar.

* Fix comment

Add another missing word.

* Fix conversion

Convert to `decimal` not `double`.

* Update snapshot

Update snapshot after merge.

* Update .NET SDK to 10.0.100-preview.5.25277.114 (#3451)

* Update .NET SDK

Update .NET SDK to version 10.0.100-preview.5.25277.114.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-version: 10.0.100-preview.5.25277.114
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Bump NuGet packages

Update NuGet packages for .NET 10 preview 5.

---------

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Martin Costello <[email protected]>

* Bump Microsoft.OpenApi

Bump Microsoft.OpenApi for .NET 10 preview 5.

* Fix build

Update `OpenApiAny` to `JsonNodeExtension`.

* Fix line endings

Fix-up line endings.

* Validate TypedResults is supported for ASP.NET Core 10 (#3455)

Co-authored-by: Javier García de la Noceda Argüelles <[email protected]>

* Support [ProducesResponseType], [Produces], and [ProducesDefaultResponseType] (#3456)

Add support for populating the description for an OpenAPI operation from `[ProducesResponseType]`, `[Produces]`, and/or `[ProducesDefaultResponseType]`.

Resolves #3099.

* Remove workarounds

Remove workarounds from earlier previews.

* Apply suggestions from code review

* Fix build

Fix build after merge.

* Fix package version

Update from preview 1 to preview 5.

* Update PublicAPI baselines

Move renames from Shipped to Unshipped files.

* Update _SdkTasksTFM

Update the value of `_SdkTasksTFM` for .NET 10.

* Update to ASP.NET Core 10 preview.6 (#3479)

Update to ASP.NET Core 10 preview 6 and Microsoft.OpenApi 2.0.0-preview.29.

* Update Microsoft.OpenApi to 2.0.0

Update to the stable release of Microsoft.OpenApi 2.0.0.

* Remove WithOpenApi usage

`WithOpenApi()` will be deprecated in .NET 10 preview 7.

See aspnet/Announcements#519.

* Remove redundant references

Remove redundant references to `Microsoft.AspNetCore.OpenApi`.

* Add UI tests for SwaggerUI and Redoc

Add end-to-end UI tests for SwaggerUI and Redoc to help validate upstream changes.

Resolves #3514.

* Update allowed licenses

Update licenses for Microsoft.OpenApi 2.0.0.

* Update to ASP.NET Core 10 preview 7

Update to preview 7 of ASP.NET Core 10.

* Remove workaround

Remove workaround for resolved issue.

* Bump Microsoft.OpenApi to 2.1.0

- Bump Microsoft.OpenApi to 2.1.0 in test projects.
- Pin to 2.0.0 in shipping packages.

* Verify OpenAPI documents

Verify there are no errors or warnings.

* Update snapshots

Update snapshot baselines.

* Apply suggestions from code review

Bump version to match other TFMs.

* Update to .NET 10 RC1 (#3556)

- Update to release candidate 1 of .NET 10.
- Fix or suppress `ASPDEPR004` and `ASPDEPR008` warnings.

* Fix deprecation warnings

Fix `ASPDEPR004` and `ASPDEPR008` warnings.

* Fix whitespace

Fix-up formatting and package versions.

* Resolve TODO

NSwag now supports .NET 10.

* Bump Duende.IdentityServer

Update Duende.IdentityServer for .NET 10.

* Simplify reference

Remove duplication by defining the reference once.

* Update documentation for v10 and OpenAPI 3.1 (#3585)

- Update the READMEs for changes in v10.
- Update most references to Swagger to OpenAPI.
- Add migration guide for v9 to v10.
- Add the version of Microsoft.OpenApi included to the version table.
- Support for generating code snippets in the documentation from code that is checked to compile.

* Fix build

Fix bad merge.

* Update Microsoft.OpenApi

Bump to v2.3.4.

* Bump Microsoft.OpenApi

Bump Microsoft.OpenApi to 2.3.5.

* Update to .NET 10 RC2

Update to Release Candidate 2 of .NET 10.

* Bump Microsoft.OpenApi

Bump Microsoft.OpenApi to 2.3.6.

* Update Microsoft.OpenApi

Update to 2.3.7.

* Bump Microsoft.OpenApi

Update to 2.3.8.

* Initialized Security property (#3635)

Avoid `NullReferenceException` in synchronous code path.

* Bump Microsoft.OpenApi

Bump Microsoft.OpenApi to 2.3.9.

* Bump Microsoft.OpenApi

Update Microsoft.OpenApi package version to 2.3.0.

* Bump Microsoft.OpenApi

Update Microsoft.OpenApi package version to 2.3.0.

* Update migration guide

- Call out some additional required changes.
- Add specific package versions.
- Link to the Microsoft.AspNetCore.OpenApi NuGet package.

* Add upgrade tip

Added a recommendation to upgrade to Swashbuckle.AspNetCore v9.0.6 before migrating to v10.

* Update to .NET 10 GA

Update to stable release of .NET 10.

---------

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bart Koelman <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Javier García de la Noceda Argüelles <[email protected]>
Co-authored-by: Javier García de la Noceda Argüelles <[email protected]>
Co-authored-by: Cesar Roux dit Buisson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants