Update to .NET 10 preview 4 and Microsoft.OpenApi 2.0.0-preview.17

[martincostello]

Update Microsoft.OpenApi to version 2.0.0-preview.17 using the latest daily build of ASP.NET Core 10 preview 4.

This PR is mainly to get a head-start on adapting to the breaking changes between 2.0.0-preview.11 and 2.0.0-preview.17 of Microsoft.OpenApi.

[codecov-commenter]

❌ 10 Tests Failed:

Tests completed	Failed	Passed	Skipped
2784	10	2774	9

View the top 3 failed test(s) by shortest run time

TestFirst.IntegrationTests.GetProductsTests::GetProducsts_Returns200_IfRequiredParametersProvided

Stack Traces | 0.00076s run time

at Swashbuckle.AspNetCore.ApiTesting.OpenApiDocumentExtensions.TryFindOperationById(OpenApiDocument openApiDocument, String operationId, String& pathTemplate, HttpMethod& operationType) in ....../_/src/Swashbuckle.AspNetCore.ApiTesting/OpenApiDocumentExtensions.cs:line 14
   at Swashbuckle.AspNetCore.ApiTesting.ApiTestRunnerBase.TestAsync(String documentName, String operationId, String expectedStatusCode, HttpRequestMessage request, HttpClient httpClient) in ....../_/src/Swashbuckle.AspNetCore.ApiTesting/ApiTestRunnerBase.cs:line 55
   at Swashbuckle.AspNetCore.ApiTesting.Xunit.ApiTestFixture`1.TestAsync(String operationId, String expectedStatusCode, HttpRequestMessage request) in ........./_/src/Swashbuckle.AspNetCore.ApiTesting.Xunit/ApiTestFixture.cs:line 25
   at TestFirst.IntegrationTests.GetProductsTests.GetProducsts_Returns200_IfRequiredParametersProvided() in .../test/WebSites/TestFirst.IntegrationTests/GetProductsTests.cs:line 18
--- End of stack trace from previous location ---

TestFirst.IntegrationTests.CreateProductTests::CreateProduct_Returns400_IfContentIsInValid

Stack Traces | 0.000934s run time

at Swashbuckle.AspNetCore.ApiTesting.OpenApiDocumentExtensions.TryFindOperationById(OpenApiDocument openApiDocument, String operationId, String& pathTemplate, HttpMethod& operationType) in ....../_/src/Swashbuckle.AspNetCore.ApiTesting/OpenApiDocumentExtensions.cs:line 14
   at Swashbuckle.AspNetCore.ApiTesting.ApiTestRunnerBase.TestAsync(String documentName, String operationId, String expectedStatusCode, HttpRequestMessage request, HttpClient httpClient) in ....../_/src/Swashbuckle.AspNetCore.ApiTesting/ApiTestRunnerBase.cs:line 55
   at Swashbuckle.AspNetCore.ApiTesting.Xunit.ApiTestFixture`1.TestAsync(String operationId, String expectedStatusCode, HttpRequestMessage request) in ........./_/src/Swashbuckle.AspNetCore.ApiTesting.Xunit/ApiTestFixture.cs:line 25
   at TestFirst.IntegrationTests.CreateProductTests.CreateProduct_Returns400_IfContentIsInValid() in .../test/WebSites/TestFirst.IntegrationTests/CreateProductTests.cs:line 33
--- End of stack trace from previous location ---

TestFirst.IntegrationTests.GetProductsTests::GetProducsts_Returns200_IfRequiredParametersProvided

Stack Traces | 0.001s run time

at Microsoft.OpenApi.Reader.OpenApiModelFactory.InternalLoad(MemoryStream input, String format, OpenApiReaderSettings settings)
   at Microsoft.OpenApi.Reader.OpenApiModelFactory.Load(MemoryStream stream, String format, OpenApiReaderSettings settings)
   at Microsoft.OpenApi.Models.OpenApiDocument.Load(MemoryStream stream, String format, OpenApiReaderSettings settings)
   at Swashbuckle.AspNetCore.ApiTesting.ApiTestRunnerOptionsExtensions.AddOpenApiFile(ApiTestRunnerOptions options, String documentName, String filePath) in ....../_/src/Swashbuckle.AspNetCore.ApiTesting/ApiTestRunnerOptionsExtensions.cs:line 15
   at TestFirst.IntegrationTests.ApiTestRunner.<>c.<.ctor>b__0_0(ApiTestRunnerOptions c) in .../test/WebSites/TestFirst.IntegrationTests/ApiTestsSetup.cs:line 18
   at Swashbuckle.AspNetCore.ApiTesting.ApiTestRunnerBase.Configure(Action`1 setupAction) in ....../_/src/Swashbuckle.AspNetCore.ApiTesting/ApiTestRunnerBase.cs:line 21
   at TestFirst.IntegrationTests.ApiTestRunner..ctor() in .../test/WebSites/TestFirst.IntegrationTests/ApiTestsSetup.cs:line 11
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[bkoelman]

It's a pain that we lost all sorting. Related conversation: microsoft/OpenAPI.NET#1314 (comment).

[martincostello]

Yeah - I was going to look tomorrow at having the code sort the lists before returning the document to the caller. It's not ideal, but it's a partial solution until/unless they revert the changes to use specific concrete types.

Subclassing List<T> might also be an option - either way is more code for us to maintain...

[bkoelman]

I wonder why they changed all signatures from IList<> to List<>, etc. If the reason is because of CA1859, subclassing is going to undo those benefits. And recursively sorting afterwards also results in a magnitude worse performance.

I quickly hacked together something here to unblock me and see what else breaks. But to do the sorting properly, it needs to be done recursively, such as here. Hope that helps.

[martincostello]

Yeah, a recursive approach was what I was going to do. I have benchmarks in a consuming repository, so I can see the effect (albeit very localised on a small API surface) after the changes to see how bad it is.

[martincostello]

Not sure why the build is failing, but (disregarding the fact it's using a daily build) this should be "done" for supporting Microsoft.OpenApi 2.0.0-preview.17.

[bkoelman]

I suspect that 04b52e9#r156107432 got lost in the conversation. The actual issue has been resolved, but the concern about copying remains.

@martincostello do you have an opinion here?

[martincostello]

Merging with dotnet test returning 1 for some unknown reason.