Skip to content

support binary charset in table option#315

Merged
fulghum merged 3 commits intomainfrom
james/binary
Mar 7, 2024
Merged

support binary charset in table option#315
fulghum merged 3 commits intomainfrom
james/binary

Conversation

@jycor
Copy link
Copy Markdown

@jycor jycor commented Mar 7, 2024

This PR adds binary as a valid charset option.
Additionally, this changes CHARSET to expand to synonym CHARACTER SET for parsing in GMS.

fixes dolthub/dolt#7576

@jycor jycor requested a review from zachmu as a code owner March 7, 2024 07:29
Copy link
Copy Markdown

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fulghum fulghum merged commit 5f7f589 into main Mar 7, 2024
@jycor jycor deleted the james/binary branch March 7, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default charset=binary is messing up in a create table statement

2 participants