Merged
Conversation
fulghum
approved these changes
Mar 7, 2024
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Tests look good. I went ahead and merged in your vitess fix so it could get bumping into GMS, too.
added 2 commits
March 7, 2024 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GMS, we reparse table options with a regular expression, but we only cover
CHARACTER SETand not its synonymCHARSET.As a result, we just ignore table options for
CHARSET.The fix is in dolthub/vitess#315
TODO: maybe should just address this TODO instead...