Merged
Conversation
fulghum
approved these changes
Jan 16, 2024
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Looks good! Would be nice to have a parse test for CHAR(... USING ...) to test that the USING clause is captured and included in the output from the Format method.
Looks like there's a skipped test related to this that could be removed, now, too:
vitess/go/vt/sqlparser/parse_test.go
Line 5423 in 4b296d3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support the charset argument for
CHAR(... using <charset>), there has to be special syntax support.Companion PR: dolthub/go-mysql-server#2255