Merged
Conversation
fulghum
reviewed
Jan 12, 2024
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Code looks good! Only reason I didn't approve yet was because I wanted to hear how much work was left to support the USING clause. Seems like we're really close and may make sense to just go ahead and knock it out, but let me know if it's more complicated than I'm thinking.
fulghum
approved these changes
Jan 16, 2024
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Very nice! Looks like this just needs some tests using USING, and then it should be good to go.
added 3 commits
January 16, 2024 11:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements most of
CHAR()functionality.Additionally, this fixes an overflow issue with
UINT32andUINT64By default, we display Bit Strings in
utf8mb4, while you need to useUSINGin MySQL.Without
USINGthe bit strings are supposed to show up as hexadecimal values.MySQL Docs: https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_char