refactoring default and on update expressions#296
Merged
Conversation
max-hoffman
approved these changes
Jan 2, 2024
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
lgtm, the specifics of the diff are a bit hard to understand but the api refactor makes sense
| func_datetime_precision: | ||
| openb value_expression closeb | ||
| // Optional datetime precision for certain functions. | ||
| func_datetime_prec_opt: |
There was a problem hiding this comment.
do we have error tests with non-integer precisions?
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the grammar to more closely match MySQL's behavior, specifically around the
NOW()function and its synonyms.Changes:
ON UPDATEexpressions against functinos that aren'tNOW()or a synonym.NOW()and synonyms; syntax error for anything elseCurTimeFuncExprfrom AST in favor of plainFuncExprCompanion PR: dolthub/go-mysql-server#2218