Conversation
max-hoffman
approved these changes
Jan 2, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
LGTM, the biggest thing I'm noticing is that we could frontload some of the precision resolving. Not blocking though
sql/expression/function/time.go
Outdated
| // Must receive integer | ||
| // Should syntax error before this; check anyway | ||
| var fsp int | ||
| switch p := prec.(type) { |
Contributor
There was a problem hiding this comment.
Lot of overlap with the default resolving, can we push all of this into planbuilder when resolving now functions? It might be easy to resolve as an integer type upfront also, one less expression to track through analysis
Contributor
Author
There was a problem hiding this comment.
It looks like there are other functions, like CURRENT_TIME and UTC_TIMESTAMP, that should be using similar logic. Will do this refactor in a follow up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has our behavior surrounding
NOW()functions more closely match MySQL.Changes:
NOW()synonyms to registryCURRENT_TIMESTAMP(),LOCALTIME(),LOCALTIMESTAMP()all just callNOW()DEFAULTandON UPDATEexpressionsSHOW CREATE TABLEto printCURRENT_TIMESTAMPforNOW()and synonymsCompanion PR: dolthub/vitess#296
Fixes:
current_timestampsynonyms dolt#7129current_timestamp()andnow()do not return the same values dolt#6058