Skip to content

Parse COLLATE BINARY on individual columns. #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicktobey merged 1 commit into from
Dec 1, 2023
Merged

Parse COLLATE BINARY on individual columns. #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions go/vt/sqlparser/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2979,6 +2979,36 @@ var (
}, {
input: "create table test (pk varchar(255)) collate utf8_unicode_ci",
output: "create table test (\n\tpk varchar(255)\n) collate utf8_unicode_ci",
}, {
input: "create table test (pk varchar(255) charset binary)",
output: "create table test (\n\tpk varchar(255) character set binary\n)",
}, {
input: "create table test (pk varchar(255) charset utf8mb4)",
output: "create table test (\n\tpk varchar(255) character set utf8mb4\n)",
}, {
input: "create table test (pk varchar(255) character set binary)",
output: "create table test (\n\tpk varchar(255) character set binary\n)",
}, {
input: "create table test (pk varchar(255) character set utf8mb4)",
output: "create table test (\n\tpk varchar(255) character set utf8mb4\n)",
}, {
input: "create table test (pk varchar(255) collate binary)",
output: "create table test (\n\tpk varchar(255) collate binary\n)",
}, {
input: "create table test (pk varchar(255) collate utf8_unicode_ci)",
output: "create table test (\n\tpk varchar(255) collate utf8_unicode_ci\n)",
}, {
input: "create table test (pk varchar(255) charset binary collate binary)",
output: "create table test (\n\tpk varchar(255) character set binary collate binary\n)",
}, {
input: "create table test (pk varchar(255) charset utf8mb4 collate utf8_unicode_ci)",
output: "create table test (\n\tpk varchar(255) character set utf8mb4 collate utf8_unicode_ci\n)",
}, {
input: "create table test (pk varchar(255) character set binary collate binary)",
output: "create table test (\n\tpk varchar(255) character set binary collate binary\n)",
}, {
input: "create table test (pk varchar(255) character set utf8mb4 collate utf8_unicode_ci)",
output: "create table test (\n\tpk varchar(255) character set utf8mb4 collate utf8_unicode_ci\n)",
}, {
input: "select * from current",
output: "select * from `current`",
Expand Down Expand Up @@ -4815,9 +4845,6 @@ func runParseTestCaseWithParserOptions(t *testing.T, tcase parseTest, options Pa
tcase.output = tcase.input
}
tree, err := ParseWithOptions(tcase.input, options)
if err != nil {
panic(tcase.input)
}
require.NoError(t, err)

assertTestcaseOutput(t, tcase, tree)
Expand Down
Loading