Parse COLLATE BINARY on individual columns.#292
Merged
Conversation
jycor
approved these changes
Nov 30, 2023
jycor
left a comment
There was a problem hiding this comment.
LGTM, maybe add tests in GMS using SHOW CREATE TABLE to make sure these are actually rewritten to varbinary.
tmp> create table t2 (i varchar(10) charset binary);
tmp> show create table t2;
+-------+------------------------------------------------------------------+
| Table | Create Table |
+-------+------------------------------------------------------------------+
| t2 | CREATE TABLE `t2` ( |
| | `i` varbinary(10) |
| | ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_bin |
+-------+------------------------------------------------------------------+
1 row in set (0.00 sec)
Author
I'll include a test like that in the GMS bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be able to parse statements like:
create table test (pk varchar(255) collate binary)This particular example will eventually get rewritten as
create table test (pk varbinary(255)), but that doesn't happen during parsing, so the added vitess tests still expectvarchar.