Route unknown-user auth failures to ER_ACCESS_DENIED for clients#3451
Merged
Route unknown-user auth failures to ER_ACCESS_DENIED for clients#3451
ER_ACCESS_DENIED for clients#3451Conversation
elianddb
changed the title
ER_ACCESS_DENIEDER_ACCESS_DENIED
elianddb
changed the title
ER_ACCESS_DENIEDER_ACCESS_DENIED for clients
elianddb
added a commit
to dolthub/dolt
that referenced
this pull request
Feb 26, 2026
elianddb
added a commit
to dolthub/dolt
that referenced
this pull request
Feb 26, 2026
elianddb
added a commit
to dolthub/dolt
that referenced
this pull request
Feb 26, 2026
elianddb
added a commit
to dolthub/dolt
that referenced
this pull request
Mar 2, 2026
… e.g. `decoyAuthSubject` and `realAuthSubject`
elianddb
added a commit
to dolthub/dolt
that referenced
this pull request
Mar 2, 2026
fulghum
reviewed
Mar 3, 2026
Contributor
fulghum
left a comment
fulghum
left a comment
There was a problem hiding this comment.
Definitely looking better! Good job simplifying the changes needed. I think you can go a little further with that.
elianddb
added a commit
to dolthub/dolt
that referenced
this pull request
Mar 4, 2026
elianddb
force-pushed
the
elian/10565
branch
3 times, most recently
from
b83eec1 to
3437350
Compare
fulghum
approved these changes
Mar 4, 2026
Comment on lines
+463
to
+464
| // newUserValidator returns a [userValidator] bound to one auth method. | ||
| // |
Contributor
There was a problem hiding this comment.
These new comment lines don't seem necessary.
elianddb
added a commit
to dolthub/dolt
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dolthub/dolt#10565
malformed packetinmariadb10.11 and 11.8 clients when using unknown user.Authentication failures for unknown users follow the
mysql_native_passwordnegotiation path instead of a handshake-level method-selection failure.