Do not wrap hoisted subquery in Limit node until AFTER checking if it's a SubqueryAlias#3427
Merged
angelamayxie merged 7 commits intomainfrom Feb 12, 2026
Merged
Do not wrap hoisted subquery in Limit node until AFTER checking if it's a SubqueryAlias#3427angelamayxie merged 7 commits intomainfrom
angelamayxie merged 7 commits intomainfrom
Conversation
This was referenced Feb 12, 2026
…o angela/notexists_findsqa
angelamayxie
changed the title
nicktobey
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapping subquery nodes in a
Limitnode before checking if it was aSubqueryAliaswas causing us to not findSubqueryAliasnodes. This was noticed when investigating dolthub/dolt#10472. We should probably be inspecting the whole node instead of simply checking the node type, but this is a quick fix.filed dolthub/dolt#10494 to add better test coverage and address TODOs