Do not push filters into SubqueryAliases that wrap RecursiveCTEs#3426
Merged
angelamayxie merged 11 commits intomainfrom Feb 12, 2026
Merged
Do not push filters into SubqueryAliases that wrap RecursiveCTEs#3426angelamayxie merged 11 commits intomainfrom
angelamayxie merged 11 commits intomainfrom
Conversation
…/dolthub/go-mysql-server into angela/notexists_lateralsubquery
angelamayxie
changed the title
angelamayxie
changed the title
angelamayxie
changed the title
…nd a RecursiveCTE
angelamayxie
changed the title
nicktobey
approved these changes
Feb 12, 2026
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes dolthub/dolt#10472
All RecursiveCTEs are wrapped by a SubqueryAlias node. We currently don't push filters through a RecursiveCTE so pushing the filter below the SubqueryAlias just causes it to be awkwardly sandwiched in between and might make some queries less optimal if the filter contains outerscope columns since the SQA gets marked as uncacheable. We probably can push filters through a RecursiveCTE in some cases, but we should spend more time thinking about what that means (see dolthub/dolt#10490).
Also contains some refactors that I noticed along the way.
skipped tests will be fixed in #3427