Conversation
Hydrocharged
approved these changes
Jun 17, 2025
sql/hash/hash.go
Outdated
Comment on lines
+63
to
+64
| // TODO: this should use types.ExtendedType.SerializeValue, but there are some doltgres conversion issues | ||
| // we need to address. Resort to old behavior for now. |
Contributor
There was a problem hiding this comment.
I'd change this to say something more along the lines of:
Doltgres follows Postgres conventions which don't align with the expectations of MySQL, so we're using the old (probably incorrect) behavior for now
SerializeValue isn't guaranteed to create comparably-unique values, which are different than truly unique values. For example, 1.0 and 1.00 are the same value via comparison, but they may be serialized differently depending on the type and whether the number of significant digits is important. In Postgres, we'd use the = operator, but GMS/MySQL doesn't have a concept of bespoke equality functions like that, hence why this doesn't really work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type/collation information to
HashOf.Additionally, it refactors
HashOfto avoid import cycles and hasgroupingKeyuse the function.fix for: dolthub/dolt#9049
doltgres fix: dolthub/doltgresql#1548