Closed
Conversation
Contributor
|
Contributor
Footnotes
|
Hydrocharged
approved these changes
Jun 17, 2025
server/expression/in_subquery.go
Outdated
Comment on lines
+102
to
+103
| // TODO: type conversions for numeric types can panic. | ||
| // TODO: this should be rType to match properly |
Collaborator
There was a problem hiding this comment.
Rather than saying this should be the right type in the TODO, I'd change it to say that hash.HashOf expects the right type, which doesn't quite align with how we handle type casting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two regressions here are not easily fixable.
The problem lies in numeric types and conversions.
When we have a float64 on the left side and a numeric (decimal type underlying), converting causes a panic.
Later on, we compare the values using a float64 comparator; it seems like the comparator wants to use left type as the comparing type, and panics if the arguments are not strictly that type.