[no-release-notes] BinaryExpression refactor#2272
Merged
Conversation
This was referenced Jan 18, 2024
max-hoffman
approved these changes
Jan 18, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
LGTM, having binary expressions share a common interface is nice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out a BinaryExpression interface. It's used in the planbuilder phase to determine the type of any bindvars in binary expressions. This makes bindvar type inference for statements like
select * from t1 where :v1 + 1 = :v2work as expected, and works for any binary expression involving a column and a bindvar.