[no-release-notes] refactoring BinaryExpression

[zachmu]

Companion to dolthub/go-mysql-server#2272

[coffeegoddd]

@zachmu DOLT

comparing_percentages
99.997743 to 99.997743

version	result	total
3613eed	not ok	134
3613eed	ok	5937323

version	total_tests
3613eed	5937457

correctness_percentage
99.997743

[coffeegoddd]

@zachmu DOLT

comparing_percentages
99.997743 to 99.997743

version	result	total
030ddc2	not ok	134
030ddc2	ok	5937323

version	total_tests
030ddc2	5937457

correctness_percentage
99.997743

[coffeegoddd]

@coffeegoddd DOLT

comparing_percentages
99.997743 to 99.997743

version	result	total
cb5379f	not ok	134
cb5379f	ok	5937323

version	total_tests
cb5379f	5937457

correctness_percentage
99.997743

[coffeegoddd]

@zachmu DOLT

comparing_percentages
99.997743 to 99.997743

version	result	total
9c1ee17	not ok	134
9c1ee17	ok	5937323

version	total_tests
9c1ee17	5937457

correctness_percentage
99.997743

[github-actions]

@coffeegoddd DOLT

test_name	detail	row_cnt	sorted	mysql_time	sql_mult	cli_mult
batching	LOAD DATA	10000	1	0.05	0.6
batching	batch sql	10000	1	0.08	1.25
batching	by line sql	10000	1	0.07	1.43
blob	1 blob	200000	1	0.87	3.23	3.61
blob	2 blobs	200000	1	0.89	3.96	4.57
blob	no blob	200000	1	0.88	1.3	1.43
col type	datetime	200000	1	0.79	1.82	1.94
col type	varchar	200000	1	0.64	2	2.02
config width	2 cols	200000	1	0.75	2.19	1.35
config width	32 cols	200000	1	1.85	1.38	2.49
config width	8 cols	200000	1	0.93	1.38	1.71
pk type	float	200000	1	0.84	1.2	1.27
pk type	int	200000	1	0.76	1.26	1.37
pk type	varchar	200000	1	1.49	1.04	0.98
row count	1.6mm	1600000	1	5.47	1.53	1.59
row count	400k	400000	1	1.38	1.46	1.52
row count	800k	800000	1	2.75	1.5	1.55
secondary index	four index	200000	1	3.5	1.09	0.94
secondary index	no secondary	200000	1	0.85	1.35	1.48
secondary index	one index	200000	1	1.11	1.46	1.49
secondary index	two index	200000	1	1.91	1.28	1.15
sorting	shuffled 1mm	1000000	0	5.05	1.86	1.85
sorting	sorted 1mm	1000000	1	5.14	1.81	1.81

[github-actions]

@coffeegoddd DOLT

name	detail	mean_mult
dolt_blame_basic	system table	1.13
dolt_blame_commit_filter	system table	2.71
dolt_commit_ancestors_commit_filter	system table	0.84
dolt_commits_commit_filter	system table	0.9
dolt_diff_log_join_from_commit	system table	1.65
dolt_diff_log_join_to_commit	system table	1.66
dolt_diff_table_from_commit_filter	system table	1.17
dolt_diff_table_to_commit_filter	system table	1.1
dolt_diffs_commit_filter	system table	1.03
dolt_history_commit_filter	system table	1.47
dolt_log_commit_filter	system table	0.94

[github-actions]

@coffeegoddd DOLT

test_name	detail	row_cnt	sorted	mysql_time	sql_mult	cli_mult
batching	LOAD DATA	10000	1	0.05	0.6
batching	batch sql	10000	1	0.08	1.25
batching	by line sql	10000	1	0.08	1.25
blob	1 blob	200000	1	0.89	3.11	3.56
blob	2 blobs	200000	1	0.9	3.9	4.5
blob	no blob	200000	1	0.88	1.3	1.42
col type	datetime	200000	1	0.8	1.75	2
col type	varchar	200000	1	0.67	1.99	1.93
config width	2 cols	200000	1	0.78	2.22	1.32
config width	32 cols	200000	1	1.89	1.34	2.48
config width	8 cols	200000	1	0.94	1.4	1.67
pk type	float	200000	1	0.87	1.23	1.24
pk type	int	200000	1	0.76	1.26	1.34
pk type	varchar	200000	1	1.49	1.03	0.97
row count	1.6mm	1600000	1	5.54	1.52	1.56
row count	400k	400000	1	1.4	1.44	1.49
row count	800k	800000	1	2.74	1.51	1.56
secondary index	four index	200000	1	3.55	1.09	0.93
secondary index	no secondary	200000	1	0.85	1.36	1.49
secondary index	one index	200000	1	1.09	1.51	1.52
secondary index	two index	200000	1	1.97	1.21	1.13
sorting	shuffled 1mm	1000000	0	5.16	1.8	1.79
sorting	sorted 1mm	1000000	1	5.07	1.87	1.83

[github-actions]

@coffeegoddd DOLT

name	detail	mean_mult
dolt_blame_basic	system table	1.09
dolt_blame_commit_filter	system table	2.7
dolt_commit_ancestors_commit_filter	system table	0.9
dolt_commits_commit_filter	system table	1
dolt_diff_log_join_from_commit	system table	1.62
dolt_diff_log_join_to_commit	system table	1.63
dolt_diff_table_from_commit_filter	system table	1.13
dolt_diff_table_to_commit_filter	system table	1.13
dolt_diffs_commit_filter	system table	0.91
dolt_history_commit_filter	system table	1.43
dolt_log_commit_filter	system table	0.9

[github-actions]

@coffeegoddd DOLT

test_name	detail	row_cnt	sorted	mysql_time	sql_mult	cli_mult
batching	LOAD DATA	10000	1	0.05	0.6
batching	batch sql	10000	1	0.07	1.43
batching	by line sql	10000	1	0.08	1.25
blob	1 blob	200000	1	0.87	3.2	3.66
blob	2 blobs	200000	1	0.86	4.09	4.77
blob	no blob	200000	1	0.9	1.28	1.38
col type	datetime	200000	1	0.83	1.73	1.88
col type	varchar	200000	1	0.65	2.02	2.03
config width	2 cols	200000	1	0.77	1.26	1.34
config width	32 cols	200000	1	2.32	1.16	2.01
config width	8 cols	200000	1	1.23	1.06	1.28
pk type	float	200000	1	0.87	1.2	1.23
pk type	int	200000	1	0.8	1.2	1.26
pk type	varchar	200000	1	1.49	1.03	0.98
row count	1.6mm	1600000	1	5.59	1.48	1.56
row count	400k	400000	1	1.4	1.42	1.5
row count	800k	800000	1	2.74	1.51	1.55
secondary index	four index	200000	1	3.55	1.09	0.94
secondary index	no secondary	200000	1	0.89	1.27	1.39
secondary index	one index	200000	1	1.09	1.53	1.51
secondary index	two index	200000	1	1.96	1.24	1.11
sorting	shuffled 1mm	1000000	0	5.24	1.79	1.79
sorting	sorted 1mm	1000000	1	5.16	1.84	1.87

[github-actions]

@coffeegoddd DOLT

name	detail	mean_mult
dolt_blame_basic	system table	1.1
dolt_blame_commit_filter	system table	2.74
dolt_commit_ancestors_commit_filter	system table	0.82
dolt_commits_commit_filter	system table	0.9
dolt_diff_log_join_from_commit	system table	1.69
dolt_diff_log_join_to_commit	system table	1.72
dolt_diff_table_from_commit_filter	system table	1.1
dolt_diff_table_to_commit_filter	system table	1.15
dolt_diffs_commit_filter	system table	1.06
dolt_history_commit_filter	system table	1.38
dolt_log_commit_filter	system table	0.94

[github-actions]

@coffeegoddd DOLT

test_name	detail	row_cnt	sorted	mysql_time	sql_mult	cli_mult
batching	LOAD DATA	10000	1	0.05	0.6
batching	batch sql	10000	1	0.07	1.43
batching	by line sql	10000	1	0.07	1.43
blob	1 blob	200000	1	0.9	3.08	3.51
blob	2 blobs	200000	1	0.87	4.1	4.67
blob	no blob	200000	1	0.87	1.32	1.44
col type	datetime	200000	1	0.79	1.8	2
col type	varchar	200000	1	0.67	1.97	2.01
config width	2 cols	200000	1	0.77	1.31	1.3
config width	32 cols	200000	1	1.84	1.4	2.92
config width	8 cols	200000	1	0.94	1.4	1.67
pk type	float	200000	1	1.14	0.9	0.94
pk type	int	200000	1	0.81	1.23	1.27
pk type	varchar	200000	1	1.68	0.89	0.86
row count	1.6mm	1600000	1	5.48	1.52	1.59
row count	400k	400000	1	1.38	1.46	1.51
row count	800k	800000	1	2.79	1.49	1.53
secondary index	four index	200000	1	3.56	1.08	0.92
secondary index	no secondary	200000	1	0.9	1.27	1.39
secondary index	one index	200000	1	1.1	1.48	1.51
secondary index	two index	200000	1	1.97	1.22	1.12
sorting	shuffled 1mm	1000000	0	5.15	1.83	1.87
sorting	sorted 1mm	1000000	1	5.22	1.8	1.8

[github-actions]

@coffeegoddd DOLT

name	detail	mean_mult
dolt_blame_basic	system table	1.1
dolt_blame_commit_filter	system table	2.68
dolt_commit_ancestors_commit_filter	system table	0.84
dolt_commits_commit_filter	system table	0.94
dolt_diff_log_join_from_commit	system table	1.65
dolt_diff_log_join_to_commit	system table	1.67
dolt_diff_table_from_commit_filter	system table	1.13
dolt_diff_table_to_commit_filter	system table	1.09
dolt_diffs_commit_filter	system table	1.03
dolt_history_commit_filter	system table	1.41
dolt_log_commit_filter	system table	0.9

[github-actions]

@coffeegoddd DOLT

test_name	detail	row_cnt	sorted	mysql_time	sql_mult	cli_mult
batching	LOAD DATA	10000	1	0.05	0.6
batching	batch sql	10000	1	0.08	1.38
batching	by line sql	10000	1	0.07	1.43
blob	1 blob	200000	1	0.92	3.01	3.38
blob	2 blobs	200000	1	0.9	3.9	4.49
blob	no blob	200000	1	0.91	1.25	1.36
col type	datetime	200000	1	0.8	1.8	1.93
col type	varchar	200000	1	0.64	1.95	2.03
config width	2 cols	200000	1	0.77	1.29	1.34
config width	32 cols	200000	1	1.86	1.37	3.11
config width	8 cols	200000	1	0.99	1.3	1.68
pk type	float	200000	1	0.85	1.19	1.22
pk type	int	200000	1	0.76	1.28	1.32
pk type	varchar	200000	1	1.53	0.97	0.96
row count	1.6mm	1600000	1	5.48	1.53	1.58
row count	400k	400000	1	1.43	1.41	1.44
row count	800k	800000	1	2.79	1.48	1.52
secondary index	four index	200000	1	3.53	1.1	0.92
secondary index	no secondary	200000	1	0.86	1.35	1.45
secondary index	one index	200000	1	1.09	1.51	1.5
secondary index	two index	200000	1	1.94	1.23	1.16
sorting	shuffled 1mm	1000000	0	4.87	1.91	1.88
sorting	sorted 1mm	1000000	1	4.94	1.88	1.86

[github-actions]

@coffeegoddd DOLT

name	detail	mean_mult
dolt_blame_basic	system table	1.11
dolt_blame_commit_filter	system table	2.74
dolt_commit_ancestors_commit_filter	system table	0.84
dolt_commits_commit_filter	system table	0.88
dolt_diff_log_join_from_commit	system table	1.64
dolt_diff_log_join_to_commit	system table	1.65
dolt_diff_table_from_commit_filter	system table	1.15
dolt_diff_table_to_commit_filter	system table	1.1
dolt_diffs_commit_filter	system table	0.97
dolt_history_commit_filter	system table	1.43
dolt_log_commit_filter	system table	0.9