Skip to content

Fixed sequences breaking some statements#1731

Merged
Hydrocharged merged 1 commit intomainfrom
daylon/sequence-breaking
Aug 8, 2025
Merged

Fixed sequences breaking some statements#1731
Hydrocharged merged 1 commit intomainfrom
daylon/sequence-breaking

Conversation

@Hydrocharged
Copy link
Collaborator

When sequences were added, some commands failed to run (reporting table not found errors). This was due to sequence names being returned in locations that Dolt expected only table names, so the returned error reflected that the table could not be found. The relevant fix is in Dolt, with this primarily adding testing.

Relies on:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Main PR
covering_index_scan_postgres 332.80/s 340.24/s +2.2%
index_join_postgres 157.17/s 156.20/s -0.7%
index_join_scan_postgres 189.28/s 188.50/s -0.5%
index_scan_postgres 12.46/s 12.07/s -3.2%
oltp_point_select 2535.06/s 2466.76/s -2.7%
oltp_read_only 1838.93/s 1796.66/s -2.3%
select_random_points 116.44/s 115.71/s -0.7%
select_random_ranges 127.41/s 130.21/s +2.1%
table_scan_postgres 11.80/s 11.63/s -1.5%
types_table_scan_postgres 5.38/s 5.37/s -0.2%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Main PR
Total 42090 42090
Successful 16723 16724
Failures 25367 25366
Partial Successes1 5545 5545
Main PR
Successful 39.7315% 39.7339%
Failures 60.2685% 60.2661%

${\color{lightgreen}Progressions (1)}$

indexing

QUERY: select indexrelid::regclass, indrelid::regclass
  from pg_index where indexrelid::regclass::text like 'idxpart%';

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hydrocharged Hydrocharged force-pushed the daylon/sequence-breaking branch from 16af0d8 to 64d7c98 Compare August 8, 2025 22:42
@Hydrocharged Hydrocharged force-pushed the daylon/sequence-breaking branch from 64d7c98 to 6dd6266 Compare August 8, 2025 22:50
@Hydrocharged Hydrocharged merged commit 2f46857 into main Aug 8, 2025
14 checks passed
@Hydrocharged Hydrocharged deleted the daylon/sequence-breaking branch August 8, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants