Skip to content

Removed root object presence from some locations#9649

Merged
Hydrocharged merged 1 commit intomainfrom
daylon/root-object-locations
Aug 8, 2025
Merged

Removed root object presence from some locations#9649
Hydrocharged merged 1 commit intomainfrom
daylon/root-object-locations

Conversation

@Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented Aug 8, 2025

Root objects occupy the same namespace as tables, however they shouldn't be returned in places that expect to see only tables. This PR allows for a distinction when querying for names, so that locations that only work with tables (such as some system tables) no longer receive root object names.

Required for:

@Hydrocharged
Copy link
Contributor Author

MySQL Client integrations are failing on other PRs too, so it seems unrelated to my changes.

@coffeegoddd
Copy link
Contributor

@Hydrocharged DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5146a0d ok 5937457
version total_tests
5146a0d 5937457
correctness_percentage
100.0

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hydrocharged Hydrocharged merged commit f010490 into main Aug 8, 2025
33 of 38 checks passed
@Hydrocharged Hydrocharged deleted the daylon/root-object-locations branch August 8, 2025 22:37
@github-actions
Copy link

github-actions bot commented Aug 9, 2025

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.67
batching batch sql 10000 1 0.08 1.63
batching by line sql 10000 1 0.1 1.3
blob 1 blob 200000 1 0.93 3.91 4.52
blob 2 blobs 200000 1 0.9 4.48 4.89
blob no blob 200000 1 0.96 2.51 2.9
col type datetime 200000 1 0.82 2.63 3
col type varchar 200000 1 0.69 3.61 3.93
config width 2 cols 200000 1 0.82 2.62 2.99
config width 32 cols 200000 1 1.93 2.52 2.77
config width 8 cols 200000 1 0.99 2.69 3.12
pk type float 200000 1 0.87 2.51 2.92
pk type int 200000 1 0.83 2.83 3.02
pk type varchar 200000 1 1.45 2.19 2.26
row count 1.6mm 1600000 1 5.79 3.12 3.3
row count 400k 400000 1 1.5 2.92 3.23
row count 800k 800000 1 2.85 3.15 3.36
secondary index four index 200000 1 3.7 1.45 1.45
secondary index no secondary 200000 1 1.04 2.36 2.62
secondary index one index 200000 1 1.2 2.49 2.71
secondary index two index 200000 1 2.03 1.88 1.92
sorting shuffled 1mm 1000000 0 5.03 3 2.84
sorting sorted 1mm 1000000 1 5.04 3.02 2.83

@github-actions
Copy link

github-actions bot commented Aug 9, 2025

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.11
dolt_blame_commit_filter system table 2.85
dolt_commit_ancestors_commit_filter system table 0.62
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.66
dolt_diff_log_join_to_commit system table 2.62
dolt_diff_table_from_commit_filter system table 1.21
dolt_diff_table_to_commit_filter system table 1.19
dolt_diffs_commit_filter system table 1.13
dolt_history_commit_filter system table 1.46
dolt_log_commit_filter system table 1.1

@github-actions
Copy link

github-actions bot commented Aug 9, 2025

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.13
adds_updates_deletes 60000 60000 60000 4.57
deletes_only 0 60000 0 2.43
updates_only 0 0 60000 2.99

@github-actions
Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.5
batching batch sql 10000 1 0.1 1.4
batching by line sql 10000 1 0.09 1.44
blob 1 blob 200000 1 0.89 4.12 4.67
blob 2 blobs 200000 1 0.86 4.77 5.12
blob no blob 200000 1 0.94 2.59 2.88
col type datetime 200000 1 0.82 2.61 3.02
col type varchar 200000 1 0.75 3.35 3.67
config width 2 cols 200000 1 0.9 2.41 2.76
config width 32 cols 200000 1 1.95 2.53 2.77
config width 8 cols 200000 1 1 2.69 3.11
pk type float 200000 1 0.86 2.53 2.93
pk type int 200000 1 0.76 3.12 3.29
pk type varchar 200000 1 1.43 1.91 2.2
row count 1.6mm 1600000 1 5.81 3.12 3.26
row count 400k 400000 1 1.61 2.76 3.01
row count 800k 800000 1 2.91 3.08 3.27
secondary index four index 200000 1 3.65 1.47 1.47
secondary index no secondary 200000 1 0.93 2.6 2.92
secondary index one index 200000 1 1.11 2.71 2.99
secondary index two index 200000 1 2 1.93 1.95
sorting shuffled 1mm 1000000 0 5.4 2.9 2.91
sorting sorted 1mm 1000000 1 5.53 2.88 2.75

@github-actions
Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.16
dolt_blame_commit_filter system table 2.85
dolt_commit_ancestors_commit_filter system table 0.62
dolt_commits_commit_filter system table 1
dolt_diff_log_join_from_commit system table 2.81
dolt_diff_log_join_to_commit system table 2.78
dolt_diff_table_from_commit_filter system table 1.24
dolt_diff_table_to_commit_filter system table 1.24
dolt_diffs_commit_filter system table 1
dolt_history_commit_filter system table 1.38
dolt_log_commit_filter system table 1.05

@github-actions
Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.13
adds_updates_deletes 60000 60000 60000 4.56
deletes_only 0 60000 0 2.39
updates_only 0 0 60000 3.01

@github-actions
Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.67
batching batch sql 10000 1 0.09 1.44
batching by line sql 10000 1 0.1 1.3
blob 1 blob 200000 1 0.9 4.01 4.6
blob 2 blobs 200000 1 0.86 4.64 5.01
blob no blob 200000 1 0.98 2.45 2.74
col type datetime 200000 1 0.81 2.64 3.05
col type varchar 200000 1 0.68 3.65 3.96
config width 2 cols 200000 1 0.94 2.26 2.66
config width 32 cols 200000 1 1.9 2.58 2.79
config width 8 cols 200000 1 0.98 2.72 3.09
pk type float 200000 1 0.88 2.52 3.3
pk type int 200000 1 2.15 1 1.24
pk type varchar 200000 1 1.46 1.84 1.99
row count 1.6mm 1600000 1 5.67 3.17 3.35
row count 400k 400000 1 1.5 2.91 3.16
row count 800k 800000 1 2.85 3.14 3.32
secondary index four index 200000 1 3.68 1.43 1.43
secondary index no secondary 200000 1 0.91 2.68 2.96
secondary index one index 200000 1 1.1 2.74 2.95
secondary index two index 200000 1 2.06 1.82 1.87
sorting shuffled 1mm 1000000 0 5.31 2.89 2.72
sorting sorted 1mm 1000000 1 4.97 3.06 2.92

@github-actions
Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.15
dolt_blame_commit_filter system table 2.82
dolt_commit_ancestors_commit_filter system table 0.62
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.77
dolt_diff_log_join_to_commit system table 2.8
dolt_diff_table_from_commit_filter system table 1.21
dolt_diff_table_to_commit_filter system table 1.21
dolt_diffs_commit_filter system table 0.97
dolt_history_commit_filter system table 1.5
dolt_log_commit_filter system table 1

@github-actions
Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.15
adds_updates_deletes 60000 60000 60000 4.54
deletes_only 0 60000 0 2.41
updates_only 0 0 60000 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants