Skip to content

Added generated system tables to pg_catalog tables#1544

Merged
zachmu merged 37 commits intomainfrom
zachmu/pgcatalog_system_tables
Jun 19, 2025
Merged

Added generated system tables to pg_catalog tables#1544
zachmu merged 37 commits intomainfrom
zachmu/pgcatalog_system_tables

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented Jun 11, 2025

Relies on dolthub/dolt#9339

Also fixes a bug in NOT IN expressions

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 11, 2025

Main PR
covering_index_scan_postgres 323.09/s 337.87/s +4.5%
index_join_postgres 154.02/s 157.73/s +2.4%
index_join_scan_postgres 184.18/s 188.82/s +2.5%
index_scan_postgres 12.49/s 12.41/s -0.7%
oltp_point_select 2505.16/s 2518.75/s +0.5%
oltp_read_only 1808.16/s 1828.52/s +1.1%
select_random_points 115.62/s 116.08/s +0.3%
select_random_ranges 127.02/s 134.90/s +6.2%
table_scan_postgres 11.69/s 11.83/s +1.1%
types_table_scan_postgres 5.40/s 5.39/s -0.2%

@zachmu zachmu requested a review from Hydrocharged June 11, 2025 23:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 12, 2025

Main PR
Total 42090 42090
Successful 16455 16459
Failures 25635 25631
Partial Successes1 5546 5547
Main PR
Successful 39.0948% 39.1043%
Failures 60.9052% 60.8957%

${\color{lightgreen}Progressions (4)}$

subselect

QUERY: SELECT 1 AS zero WHERE 1 NOT IN (SELECT 1);
QUERY: SELECT ss.f1 AS "Correlated Field", ss.f3 AS "Second Field"
  FROM SUBSELECT_TBL ss
  WHERE f1 NOT IN (SELECT f1+1 FROM INT4_TBL
                   WHERE f1 != ss.f1 AND f1 < 2147483647);
QUERY: select * from notinouter where a not in (select b from notininner);
QUERY: select * from
(values
  (3 not in (select * from (values (1), (2)) ss1)),
  (false)
) ss;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm not seeing any reason as to why this is slowing down the regression tests, logically it looks like it should be completely fine.

@zachmu zachmu enabled auto-merge June 19, 2025 01:48
@zachmu zachmu merged commit f70b2f0 into main Jun 19, 2025
14 checks passed
@zachmu zachmu deleted the zachmu/pgcatalog_system_tables branch June 19, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants