Skip to content

Utility method to list all system tables in a schema#9339

Merged
zachmu merged 13 commits intomainfrom
zachmu/sys_tables
Jun 19, 2025
Merged

Utility method to list all system tables in a schema#9339
zachmu merged 13 commits intomainfrom
zachmu/sys_tables

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented Jun 11, 2025

Needed for doltgres, to put generated system tables in pg_catalog tables.

@coffeegoddd
Copy link
Copy Markdown
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4675459 ok 5937457
version total_tests
4675459 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
86d169e ok 5937457
version total_tests
86d169e 5937457
correctness_percentage
100.0

@zachmu zachmu requested a review from Hydrocharged June 11, 2025 23:52
Copy link
Copy Markdown
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Copy Markdown
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0686118 ok 5937457
version total_tests
0686118 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8831317 ok 5937457
version total_tests
8831317 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
47d7fe3 ok 5937457
version total_tests
47d7fe3 5937457
correctness_percentage
100.0

@zachmu
Copy link
Copy Markdown
Member Author

zachmu commented Jun 19, 2025

#benchmark

@github-actions
Copy link
Copy Markdown

@coffeegoddd
Copy link
Copy Markdown
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
233d166 ok 5937457
version total_tests
233d166 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@zachmu DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 63.32 61.08 -3.54
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt d839ca0 38.86 dolt 233d166 39.32 1.18

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
459091c ok 5937457
version total_tests
459091c 5937457
correctness_percentage
100.0

@zachmu zachmu merged commit a87c3da into main Jun 19, 2025
21 checks passed
@coffeegoddd
Copy link
Copy Markdown
Contributor

@zachmu DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.68 0.67 -1.47
groupby_scan 19.65 19.29 -1.83
index_join 2.57 2.52 -1.95
index_join_scan 1.44 1.44 0.0
index_scan 30.26 29.72 -1.78
oltp_point_select 0.29 0.28 -3.45
oltp_read_only 5.37 5.28 -1.68
select_random_points 0.61 0.6 -1.64
select_random_ranges 0.64 0.62 -3.13
table_scan 32.53 31.94 -1.81
types_table_scan 127.81 125.52 -1.79
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.67 6.55 -1.8
oltp_insert 3.25 3.25 0.0
oltp_read_write 11.87 11.65 -1.85
oltp_update_index 3.36 3.3 -1.79
oltp_update_non_index 3.25 3.25 0.0
oltp_write_only 6.55 6.43 -1.83
types_delete_insert 6.91 6.91 0.0

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.29
batching batch sql 10000 1 0.09 1.44
batching by line sql 10000 1 0.1 1.2
blob 1 blob 200000 1 0.9 3.91 4.63
blob 2 blobs 200000 1 0.89 4.45 4.74
blob no blob 200000 1 1.05 2.18 2.52
col type datetime 200000 1 0.81 2.54 2.95
col type varchar 200000 1 0.72 3.38 3.82
config width 2 cols 200000 1 0.91 2.26 2.59
config width 32 cols 200000 1 1.95 1.96 2.68
config width 8 cols 200000 1 0.94 2.52 2.81
pk type float 200000 1 0.88 2.39 2.74
pk type int 200000 1 0.83 2.46 2.81
pk type varchar 200000 1 1.5 1.94 1.91
row count 1.6mm 1600000 1 5.71 3.05 3.1
row count 400k 400000 1 1.54 2.71 2.88
row count 800k 800000 1 2.98 2.85 3.02
secondary index four index 200000 1 3.68 1.41 1.32
secondary index no secondary 200000 1 0.93 2.43 2.83
secondary index one index 200000 1 1.16 2.43 2.57
secondary index two index 200000 1 2.03 1.81 1.9
sorting shuffled 1mm 1000000 0 5.62 2.72 2.68
sorting sorted 1mm 1000000 1 5.51 2.76 2.72

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.15
dolt_blame_commit_filter system table 2.93
dolt_commit_ancestors_commit_filter system table 0.58
dolt_commits_commit_filter system table 1.1
dolt_diff_log_join_from_commit system table 2.78
dolt_diff_log_join_to_commit system table 2.71
dolt_diff_table_from_commit_filter system table 1.24
dolt_diff_table_to_commit_filter system table 1.22
dolt_diffs_commit_filter system table 1.06
dolt_history_commit_filter system table 1.48
dolt_log_commit_filter system table 1.1

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.11
adds_updates_deletes 60000 60000 60000 4.64
deletes_only 0 60000 0 2.38
updates_only 0 0 60000 3.04

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.29
batching batch sql 10000 1 0.1 1.2
batching by line sql 10000 1 0.09 1.33
blob 1 blob 200000 1 0.92 3.79 4.5
blob 2 blobs 200000 1 0.95 4.12 4.53
blob no blob 200000 1 1 2.27 2.63
col type datetime 200000 1 0.83 2.46 2.9
col type varchar 200000 1 0.8 3.03 3.39
config width 2 cols 200000 1 0.82 2.5 2.89
config width 32 cols 200000 1 1.97 1.97 2.67
config width 8 cols 200000 1 1 2.37 2.66
pk type float 200000 1 0.85 2.51 2.86
pk type int 200000 1 0.97 2.29 2.4
pk type varchar 200000 1 2.84 0.93 1.08
row count 1.6mm 1600000 1 5.75 3.02 3.13
row count 400k 400000 1 1.6 2.63 2.84
row count 800k 800000 1 2.94 2.91 3.09
secondary index four index 200000 1 3.66 1.4 1.34
secondary index no secondary 200000 1 0.95 2.4 2.79
secondary index one index 200000 1 1.17 2.45 2.55
secondary index two index 200000 1 2.06 1.79 1.87
sorting shuffled 1mm 1000000 0 5.36 2.87 2.78
sorting sorted 1mm 1000000 1 5.3 2.89 2.8

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.16
dolt_blame_commit_filter system table 2.9
dolt_commit_ancestors_commit_filter system table 0.65
dolt_commits_commit_filter system table 1.1
dolt_diff_log_join_from_commit system table 2.8
dolt_diff_log_join_to_commit system table 2.75
dolt_diff_table_from_commit_filter system table 1.18
dolt_diff_table_to_commit_filter system table 1.19
dolt_diffs_commit_filter system table 1
dolt_history_commit_filter system table 1.48
dolt_log_commit_filter system table 1.1

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.13
adds_updates_deletes 60000 60000 60000 4.5
deletes_only 0 60000 0 2.38
updates_only 0 0 60000 3.02

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.29
batching batch sql 10000 1 0.09 1.33
batching by line sql 10000 1 0.1 1.3
blob 1 blob 200000 1 0.92 3.71 4.51
blob 2 blobs 200000 1 0.89 4.28 4.69
blob no blob 200000 1 0.94 2.41 2.83
col type datetime 200000 1 0.82 2.49 2.84
col type varchar 200000 1 0.73 3.27 3.67
config width 2 cols 200000 1 0.81 2.54 2.96
config width 32 cols 200000 1 1.91 2 2.74
config width 8 cols 200000 1 0.98 2.43 2.7
pk type float 200000 1 0.83 2.52 2.89
pk type int 200000 1 0.81 2.64 2.89
pk type varchar 200000 1 1.52 1.74 2.17
row count 1.6mm 1600000 1 5.81 2.97 3.04
row count 400k 400000 1 1.48 2.82 3.03
row count 800k 800000 1 2.84 3.01 3.12
secondary index four index 200000 1 3.7 1.37 1.32
secondary index no secondary 200000 1 1.02 2.22 2.58
secondary index one index 200000 1 1.18 2.4 2.49
secondary index two index 200000 1 2.05 1.76 1.87
sorting shuffled 1mm 1000000 0 5.25 2.86 2.74
sorting sorted 1mm 1000000 1 5.24 2.84 2.69

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.15
dolt_blame_commit_filter system table 2.92
dolt_commit_ancestors_commit_filter system table 0.63
dolt_commits_commit_filter system table 1.1
dolt_diff_log_join_from_commit system table 2.83
dolt_diff_log_join_to_commit system table 2.84
dolt_diff_table_from_commit_filter system table 1.24
dolt_diff_table_to_commit_filter system table 1.24
dolt_diffs_commit_filter system table 1.03
dolt_history_commit_filter system table 1.44
dolt_log_commit_filter system table 1.1

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.12
adds_updates_deletes 60000 60000 60000 4.52
deletes_only 0 60000 0 2.4
updates_only 0 0 60000 3.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants