Merged PRs
dolt
- 8576: Change LateBindQueryist to use
mysql.NewSalt()
In preparation for refactoring the auth server interface in Vitess/GMS, this change makes LateBindQueryist callmysql.NewSalt()
directly, instead of relying on theNewSalt()
method on theMySQLDb
instance (which internally callsmysql.NewSalt()
).
go-mysql-server
- 2753: Fixes CTE issue with auth
This fixes the test introduced in:- dolthub/go-mysql-server#2745
Related PR: - dolthub/vitess#377
- dolthub/go-mysql-server#2745
- 2750: Fix alter NULL enum value panic
- 2739: Embed the
embedded.Tracer
into memTracer, to fulfil the updated interface
I was trying to use this projectgo-mysql-server
as a dependency alongside github.com/grafana/grafana-plugin-sdk-go/data. But the latter project depends on:- go.opentelemetry.io/otel v1.31.0
- go.opentelemetry.io/otel/trace v1.31.0
When I updated my go modules withgo mod tidy
I started to hit a compilation error:
Hence this change 🙏# github.com/dolthub/go-mysql-server/test /Users/samjewell/go/pkg/mod/github.com/dolthub/[email protected]/test/mem_tracer.go:22:2: could not import go.opentelemetry.io/otel/trace/embedded (open : no such file or directory) FAIL github.com/grafana/poc-sql-expressions-embedded-sql/dolthub-go-mysql-server [build failed] FAIL
vitess
- 378: support
set names binary
syntax (no quotes)
syntax for: #8574 - 377: Fixed CTE issue with auth
Fixes the test introduced in: - 375: support multiple like tables
Closed Issues
- 8574:
set names binary
fails.set names 'binary'
succeeds. Seems unquoted collations in MySQL are supposed to work withset names
Performance
Read Tests | MySQL | Dolt | Multiple |
---|---|---|---|
covering_index_scan | 2.14 | 0.62 | 0.3 |
groupby_scan | 13.22 | 17.01 | 1.3 |
index_join | 1.34 | 2.3 | 1.7 |
index_join_scan | 1.27 | 1.89 | 1.5 |
index_scan | 34.33 | 55.82 | 1.6 |
oltp_point_select | 0.18 | 0.27 | 1.5 |
oltp_read_only | 3.49 | 5.57 | 1.6 |
select_random_points | 0.34 | 0.67 | 2.0 |
select_random_ranges | 0.39 | 0.67 | 1.7 |
table_scan | 34.95 | 55.82 | 1.6 |
types_table_scan | 75.82 | 144.97 | 1.9 |
reads_mean_multiplier | 1.5 |
Write Tests | MySQL | Dolt | Multiple |
---|---|---|---|
oltp_delete_insert | 7.98 | 5.88 | 0.7 |
oltp_insert | 3.75 | 2.91 | 0.8 |
oltp_read_write | 8.58 | 11.45 | 1.3 |
oltp_update_index | 3.82 | 2.97 | 0.8 |
oltp_update_non_index | 3.89 | 2.91 | 0.7 |
oltp_write_only | 5.28 | 5.88 | 1.1 |
types_delete_insert | 7.7 | 6.21 | 0.8 |
writes_mean_multiplier | 0.9 |
TPC-C TPS Tests | MySQL | Dolt | Multiple |
---|---|---|---|
tpcc-scale-factor-1 | 98.98 | 40.93 | 2.4 |
tpcc_tps_multiplier | 2.4 |
Overall Mean Multiple | 1.60 |
---|