Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed the embedded.Tracer into memTracer, to fulfil the updated interface #2739

Conversation

samjewell
Copy link
Contributor

I was trying to use this project go-mysql-server as a dependency alongside github.com/grafana/grafana-plugin-sdk-go/data. But the latter project depends on:

  • go.opentelemetry.io/otel v1.31.0
  • go.opentelemetry.io/otel/trace v1.31.0

When I updated my go modules with go mod tidy I started to hit a compilation error:

# github.com/dolthub/go-mysql-server/test
/Users/samjewell/go/pkg/mod/github.com/dolthub/[email protected]/test/mem_tracer.go:22:2: could not import go.opentelemetry.io/otel/trace/embedded (open : no such file or directory)
FAIL	github.com/grafana/poc-sql-expressions-embedded-sql/dolthub-go-mysql-server [build failed]
FAIL

Hence this change 🙏

@samjewell
Copy link
Contributor Author

@jycor / @Hydrocharged any thoughts on this one 🙏 ?

@zachmu
Copy link
Member

zachmu commented Nov 11, 2024

@max-hoffman you want to take a look at this? Not sure how it affects our upstreams.

@max-hoffman
Copy link
Contributor

@max-hoffman you want to take a look at this? Not sure how it affects our upstreams.

The hosted API and DoltHub remote API are the only services that use OTEL as far as I can tell. So if the version bump is not backwards compatible LD will need a PR for interface changes. Removing the OTEL dependency from GMS would probably also work. Merging this PR as is would probably be OK.

@samjewell
Copy link
Contributor Author

Hey team. Any update on this? It's something of a thorn in my side right now, so I'm interested 👀

@max-hoffman
Copy link
Contributor

I'll merge, if there are further conflicts I will loop back and just remove the dependency.

@max-hoffman max-hoffman merged commit efb1484 into dolthub:main Nov 19, 2024
9 checks passed
@max-hoffman
Copy link
Contributor

Thanks for taking the time to contribute @samjewell :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants