reduce creation of new strings and []string

[jycor]

Changes:

• reduces string operations by caching the revision database name

Companion PR: dolthub/go-mysql-server#3158

[jycor]

#benchmark

[github-actions]

@jycor workflow run: https://github.com/dolthub/dolt/actions/runs/16947321531

[coffeegoddd]

@jycor DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	66.84	62.19	-6.96

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	ca24b4f	38.09	dolt	fff466e	39.54	3.81

[coffeegoddd]

@jycor DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.69	0.68	-1.45
groupby_scan	20.0	20.0	0.0
index_join	2.61	2.61	0.0
index_join_scan	1.47	1.44	-2.04
index_scan	31.37	31.37	0.0
oltp_point_select	0.29	0.29	0.0
oltp_read_only	5.37	5.37	0.0
select_random_points	0.62	0.62	0.0
select_random_ranges	0.64	0.64	0.0
table_scan	33.12	33.12	0.0
types_table_scan	130.13	130.13	0.0

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.67	6.67	0.0
oltp_insert	3.25	3.25	0.0
oltp_read_write	11.87	11.87	0.0
oltp_update_index	3.36	3.36	0.0
oltp_update_non_index	3.25	3.25	0.0
oltp_write_only	6.55	6.55	0.0
types_delete_insert	7.04	7.04	0.0

[jycor]

#benchmark

[github-actions]

@jycor workflow run: https://github.com/dolthub/dolt/actions/runs/16951316059

[coffeegoddd]

@jycor DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	61.08	65.65	7.48

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	29131b1	38.85	dolt	0359404	38.62	-0.59

[coffeegoddd]

@jycor DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.68	0.68	0.0
groupby_scan	19.65	18.95	-3.56
index_join	2.52	2.48	-1.59
index_join_scan	1.44	1.44	0.0
index_scan	31.37	30.81	-1.79
oltp_point_select	0.29	0.29	0.0
oltp_read_only	5.37	5.37	0.0
select_random_points	0.61	0.61	0.0
select_random_ranges	0.63	0.63	0.0
table_scan	32.53	33.12	1.81
types_table_scan	130.13	127.81	-1.78

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.55	6.55	0.0
oltp_insert	3.25	3.25	0.0
oltp_read_write	11.87	11.87	0.0
oltp_update_index	3.3	3.3	0.0
oltp_update_non_index	3.25	3.25	0.0
oltp_write_only	6.55	6.55	0.0
types_delete_insert	6.91	6.91	0.0

[jycor]

#benchmark

[github-actions]

@jycor workflow run: https://github.com/dolthub/dolt/actions/runs/16978101417

[coffeegoddd]

@jycor DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
6ae4f4a	ok	5937457

version	total_tests
6ae4f4a	5937457

correctness_percentage
100.0

[coffeegoddd]

@jycor DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	63.32	66.84	5.56

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	7614229	38.88	dolt	6ae4f4a	38.8	-0.21

[coffeegoddd]

@jycor DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.69	0.68	-1.45
groupby_scan	19.29	18.95	-1.76
index_join	2.52	2.48	-1.59
index_join_scan	1.47	1.44	-2.04
index_scan	31.37	30.81	-1.79
oltp_point_select	0.29	0.29	0.0
oltp_read_only	5.37	5.37	0.0
select_random_points	0.61	0.61	0.0
select_random_ranges	0.64	0.63	-1.56
table_scan	32.53	33.12	1.81
types_table_scan	130.13	127.81	-1.78

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.67	6.55	-1.8
oltp_insert	3.25	3.25	0.0
oltp_read_write	11.87	11.87	0.0
oltp_update_index	3.3	3.3	0.0
oltp_update_non_index	3.25	3.25	0.0
oltp_write_only	6.55	6.55	0.0
types_delete_insert	6.91	6.91	0.0

[coffeegoddd]

@jycor DOLT

comparing_percentages
100.000000 to 95.343697

version	result	total
9af8f59	not ok	276466
9af8f59	ok	5660991

version	total_tests
9af8f59	5937457

correctness_percentage
95.343697

[coffeegoddd]

@jycor DOLT

comparing_percentages
100.000000 to 95.343697

version	result	total
d811d6b	not ok	276466
d811d6b	ok	5660991

version	total_tests
d811d6b	5937457

correctness_percentage
95.343697

[coffeegoddd]

@jycor DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
f7db7b9	ok	5937457

version	total_tests
f7db7b9	5937457

correctness_percentage
100.0

[coffeegoddd]

@jycor DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
1fc0776	ok	5937457

version	total_tests
1fc0776	5937457

correctness_percentage
100.0

[jycor]

#benchmark

[github-actions]

@jycor workflow run: https://github.com/dolthub/dolt/actions/runs/17055497110

[coffeegoddd]

@jycor DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	62.19	61.08	-1.78

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	74339f1	38.67	dolt	1fc0776	38.98	0.8

[coffeegoddd]

@jycor DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.69	0.68	-1.45
groupby_scan	19.29	19.29	0.0
index_join	2.57	2.48	-3.5
index_join_scan	1.44	1.44	0.0
index_scan	31.37	31.37	0.0
oltp_point_select	0.29	0.28	-3.45
oltp_read_only	5.37	5.37	0.0
select_random_points	0.61	0.61	0.0
select_random_ranges	0.64	0.63	-1.56
table_scan	32.53	32.53	0.0
types_table_scan	130.13	127.81	-1.78

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.55	6.55	0.0
oltp_insert	3.25	3.25	0.0
oltp_read_write	11.87	11.87	0.0
oltp_update_index	3.3	3.3	0.0
oltp_update_non_index	3.25	3.25	0.0
oltp_write_only	6.55	6.55	0.0
types_delete_insert	6.91	6.91	0.0

[fulghum]

LGTM

[coffeegoddd]

@jycor DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
4ba97e6	ok	5937457

version	total_tests
4ba97e6	5937457

correctness_percentage
100.0