cache sql.Schema in plan.Project and plan.TableAlias#3158
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
plan.Project.Schema()andplan.TableAlias.Schema()create a newsql.Schemaevery time they are called, which can be a lot during analysis. So, the results are cached.sql.Index.Expressions()retrieves a new[]string, so we should cache that as well. Additionally, many times we unqualify the results,so I added aUnqualifiedExpressions()to avoid doing this extra processing every time.idxExprsColumnsto avoid usingstrings.Splitto avoid extra allocations